[multi-asic] Support per-ASIC /host/warmboot$DEV #25071
Merged
liat-grozovik merged 8 commits intosonic-net:masterfrom Mar 4, 2026
Merged
[multi-asic] Support per-ASIC /host/warmboot$DEV #25071liat-grozovik merged 8 commits intosonic-net:masterfrom
liat-grozovik merged 8 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oleksandrivantsiv
approved these changes
Jan 23, 2026
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
f74ed42 to
fff111d
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Mar 4, 2026
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
- Why I did it Use /host/warmboot$DEV as warmboot directory in scripts to support Multi-ASIC devices. $DEV is empty for single-ASIC device - no path change in this case. - How I did it Add $DEV as a suffix in scripts. - How to verify it Run on Multi-ASIC device. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com> Signed-off-by: Feng Pan <fenpan@microsoft.com>
lipxu
added a commit
to lipxu/sonic-buildimage
that referenced
this pull request
Mar 20, 2026
…rcm-legacy-th.mk PR sonic-net#25071 migrated warmboot mounts from the static -v /host/warmboot:/var/warmboot in .mk files to a dynamic -v /host/warmbootDEV:/var/warmboot generated at runtime via docker_image_ctl.j2 to support multi-ASIC devices. However, it missed updating docker-syncd-brcm-legacy-th.mk. This commit applies the same fix to align with the changes introduced in PR sonic-net#25071. Note: docker-syncd-brcm-legacy-th-rpc.mk will be updated in a follow-up commit once PR sonic-net#26215 is merged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: xuliping@microsoft.com <xuliping@microsoft.com>
6 tasks
lipxu
added a commit
to lipxu/sonic-buildimage
that referenced
this pull request
Mar 26, 2026
…rcm-legacy-th.mk PR sonic-net#25071 migrated warmboot mounts from the static -v /host/warmboot:/var/warmboot in .mk files to a dynamic -v /host/warmbootDEV:/var/warmboot generated at runtime via docker_image_ctl.j2 to support multi-ASIC devices. However, it missed updating docker-syncd-brcm-legacy-th.mk. This commit applies the same fix to align with the changes introduced in PR sonic-net#25071. Note: docker-syncd-brcm-legacy-th-rpc.mk will be updated in a follow-up commit once PR sonic-net#26215 is merged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: xuliping@microsoft.com <xuliping@microsoft.com>
lipxu
added a commit
to lipxu/sonic-buildimage
that referenced
this pull request
Mar 26, 2026
…rcm-legacy-th-rpc.mk Now that docker-syncd-brcm-legacy-th-rpc.mk exists (added by PR sonic-net#26340), apply the same warmboot mount fix: remove the static -v /host/warmboot:/var/warmboot in favour of the dynamic mount generated at runtime via docker_image_ctl.j2 (consistent with PR sonic-net#25071 and the companion fix in docker-syncd-brcm-legacy-th.mk). Signed-off-by: xuliping@microsoft.com <xuliping@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HLD - Warm-reboot multi-ASIC HLD
Why I did it
Use
/host/warmboot$DEVas warmboot directory in scripts to support Multi-ASIC devices.$DEV is empty for single-ASIC device - no path change in this case.
Work item tracking
How I did it
Add $DEV as a suffix in scripts.
How to verify it
Run on Multi-ASIC device.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)