Move media_settings.json to platform directory#24884
Merged
lguohan merged 7 commits intosonic-net:masterfrom Jan 16, 2026
Merged
Move media_settings.json to platform directory#24884lguohan merged 7 commits intosonic-net:masterfrom
lguohan merged 7 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
Move the media_settings.json from the hwsku folder to the parent platform directory since it can be shared across many hwskus for this hardware platform. Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
bbc8f0e to
96f389a
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
approved these changes
Jan 7, 2026
prgeor
reviewed
Jan 7, 2026
Contributor
There was a problem hiding this comment.
@bgallagher-nexthop is this a symlink? I don't see any content in the file
Contributor
Author
There was a problem hiding this comment.
No symlink -- it contains the JSON content, but Github doesn't seem to render any diff for this since it was just a file rename without any other changes:
git mv device/nexthop/x86_64-nexthop_5010-r0/NH-5010-F-064/media_settings.json device/nexthop/x86_64-nexthop_5010-r0/media_settings.json
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
6 tasks
Collaborator
|
Cherry-pick PR to 202511: #25179 |
Collaborator
|
@bgallagher-nexthop cherry pick PR didn't pass PR checker. Please check!!! |
3 similar comments
Collaborator
|
@bgallagher-nexthop cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@bgallagher-nexthop cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@bgallagher-nexthop cherry pick PR didn't pass PR checker. Please check!!! |
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…24884) Move the media_settings.json from the hwsku folder to the parent platform directory since it can be shared across many hwskus for this hardware platform. Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai> Co-authored-by: arpit-nexthop <arpit@nexthop.ai> Co-authored-by: saravanan sellappa <saravanan@nexthop.ai> Signed-off-by: Feng Pan <fenpan@microsoft.com>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
Move the media_settings.json from the hwsku folder to the parent platform directory since it can be shared across many hwskus for this hardware platform. Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai> Co-authored-by: arpit-nexthop <arpit@nexthop.ai> Co-authored-by: saravanan sellappa <saravanan@nexthop.ai> Signed-off-by: dprital <drorp@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Move the media_settings.json from the hwsku folder to the parent platform directory since it can be shared across many hwskus for this hardware platform.
Work item tracking
N/A
How I did it
I moved x86_64-nexthop_5010-r0/NH-5010-F-O64/media_settings.json to x86_64-nexthop_5010-r0/media_settings.json.
How to verify it
Manually tested the change on an in-house device.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
N/A
Description for the changelog
Move the media_settings.json from the hwsku folder to the parent platform directory since it can be shared across many hwskus for the x86_64-nexthop_5010-r0 hardware platform.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)