Remove logging flags for p4rt_app.#24747
Merged
baxia-lan merged 1 commit intosonic-net:masterfrom Jan 13, 2026
Merged
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
6eef3a5 to
7cfc547
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
7cfc547 to
7f5ebb9
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: rhalstea <rhalstea@google.com>
7f5ebb9 to
cdf4e3c
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@divyagayathri-hcl Please update the description with why these changes are done. |
kishanps
approved these changes
Jan 13, 2026
Contributor
|
Adding @baxia-lan for review and merge. |
baxia-lan
approved these changes
Jan 13, 2026
jasonbridges
pushed a commit
to jasonbridges/sonic-buildimage
that referenced
this pull request
Jan 22, 2026
Signed-off-by: rhalstea <rhalstea@google.com> Co-authored-by: rhalstea <rhalstea@google.com>
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
Signed-off-by: rhalstea <rhalstea@google.com> Co-authored-by: rhalstea <rhalstea@google.com> Signed-off-by: Feng Pan <fenpan@microsoft.com>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
Signed-off-by: rhalstea <rhalstea@google.com> Co-authored-by: rhalstea <rhalstea@google.com> Signed-off-by: dprital <drorp@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
We are migrating from GLOG to absl/log in sonic-pins and absl/log does not use
these flags. By default, it already outputs to stderr.
How to verify it
With this arguments, the p4rt docker is crashing while loading the sonic-vs image.
After removing the arguments, we are able to make the p4rt docker up without any crash.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)