Skip to content

Update sai_stats_support_mask from 0x80 to 0x880 to remove PFC pause from port counter #23772

Merged
yxieca merged 3 commits intomasterfrom
update_sai_stats_support_mask
Sep 19, 2025
Merged

Update sai_stats_support_mask from 0x80 to 0x880 to remove PFC pause from port counter #23772
yxieca merged 3 commits intomasterfrom
update_sai_stats_support_mask

Conversation

@bingwang-ms
Copy link
Copy Markdown
Contributor

@bingwang-ms bingwang-ms commented Aug 20, 2025 •
edited
Loading

…e frames

Why I did it

This PR is to set sai_stats_support_mask to 0x880 for a series of Arista HWSKUs.

Work item tracking
  • Microsoft ADO 34515971:
  • CSP CS00012419125

How I did it

Update config.bcm

How to verify it

The change is verified by running PFCWD test on a physical testbed.

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Set sai_stats_support_mask to 0x480 for a series of Arista HWSKUs.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Aug 20, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Aug 20, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms mentioned this pull request Aug 20, 2025
Merged
@bingwang-ms
Copy link
Copy Markdown
Contributor Author

bingwang-ms commented Aug 20, 2025

@r12f @BYGX-wcr Can you please help review?

bingwang-ms added a commit to Azure/sonic-buildimage-msft that referenced this pull request Aug 22, 2025
@bingwang-ms
[202503] Update sai_stats_support_mask from 0x80 to 0x480 to remove P…
0467694 
…FC pause from port counter (#1542)

Cherry-pick sonic-net/sonic-buildimage#23772
BYGX-wcr
BYGX-wcr approved these changes Sep 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@BYGX-wcr BYGX-wcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kperumalbfn
kperumalbfn reviewed Sep 2, 2025
View reviewed changes
.../arista/x86_64-arista_7060x6_64pe_b/Arista-7060X6-64PE-B-C448O16/th5-a7060x6-64pe.config.bcm Outdated
global:
ftem_mem_entries: 65536
sai_stats_support_mask: 0x80
sai_stats_support_mask: 0x480
Copy link
Copy Markdown
Contributor

@kperumalbfn kperumalbfn Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these counters are removed from port?

Copy link
Copy Markdown
Contributor Author

@bingwang-ms bingwang-ms Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to mask out PFC pause frame from drop counter.

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Sep 19, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 19, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms changed the title Update sai_stats_support_mask from 0x80 to 0x480 to remove PFC pause from port counter Update sai_stats_support_mask from 0x80 to 0x880 to remove PFC pause from port counter Sep 19, 2025
kperumalbfn
kperumalbfn approved these changes Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kperumalbfn kperumalbfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kperumalbfn kperumalbfn mentioned this pull request Sep 19, 2025
Merged
10 tasks
@bingwang-ms bingwang-ms mentioned this pull request Sep 19, 2025
Merged
9 tasks
bingwang-ms added a commit to Azure/sonic-buildimage-msft that referenced this pull request Sep 19, 2025
@bingwang-ms
Update mask code from 0x480 to 0x880 (#1641)
62295fa 
…e frames

<!--
Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

** Make sure all your commits include a signature generated with `git
commit -s` **

If this is a bug fix, make sure your description includes "fixes #xxxx",
or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it
This PR is to set `sai_stats_support_mask` to `0x880` for a series of
Arista HWSKUs.
Cherry-pick sonic-net/sonic-buildimage#23772

##### Work item tracking
- Microsoft ADO **34515971**:
- CSP **CS00012419125**

#### How I did it
Update config.bcm

#### How to verify it
The change is verified by running PFCWD test on a physical testbed.

<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202505

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 202503
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
Set `sai_stats_support_mask` to `0x480` for a series of Arista HWSKUs.

<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
dakotac-arista added a commit to dakotac-arista/sonic-buildimage that referenced this pull request Sep 19, 2025
@dakotac-arista
Update sai_stats_support_mask to 0x880
199d2be 
Applying change from PR:
sonic-net#23772
@yxieca yxieca merged commit 1571dd0 into master Sep 19, 2025
20 checks passed
@yxieca yxieca deleted the update_sai_stats_support_mask branch September 19, 2025 23:05
@bingwang-ms bingwang-ms mentioned this pull request Sep 19, 2025
Merged
9 tasks
@sdszhang sdszhang mentioned this pull request Sep 21, 2025
Merged
9 tasks
yejianquan pushed a commit that referenced this pull request Sep 23, 2025
@bingwang-ms
[202505] Update sai_stats_support_mask from 0x80 to 0x880 to mask off…
09434c2 
… PFC pause frames (#24057)

Cherry-pick from #23772

Why I did it
This PR is to set sai_stats_support_mask to 0x880 for a series of Arista HWSKUs.

Work item tracking
Microsoft ADO 34515971:
CSP CS00012419125
How I did it
Update config.bcm

How to verify it
The change is verified by running PFCWD test on a physical testbed.


Tested branch (Please provide the tested image version)


Description for the changelog
Set sai_stats_support_mask to 0x480 for a series of Arista HWSKUs.

signed-off-by: jianquanye@microsoft.com
StormLiangMS pushed a commit that referenced this pull request Sep 25, 2025
@sdszhang
Update sai_stats_support_mask for Moby hwsku to remove PFC pause from…
48bd7d2 
… port counter (#24062)

Why I did it
This PR is to set sai_stats_support_mask to 0x800 for Moby HWSKUs. This is a continuation of #23772

Work item tracking
Microsoft ADO 34515971:
CSP CS00012419125
How I did it
Update config.bcm

How to verify it
The change is verified by running PFCWD test on a physical testbed.
mssonicbld added a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 26, 2025
@mssonicbld
Update sai_stats_support_mask for Moby hwsku to remove PFC pause fro…
38642e8 
…m port counter

<!--
     Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

     ** Make sure all your commits include a signature generated with `git commit -s` **

     If this is a bug fix, make sure your description includes "fixes #xxxx", or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->
#### Why I did it
This PR is to set `sai_stats_support_mask` to `0x800` for Moby HWSKUs. This is a continuation of sonic-net#23772

##### Work item tracking
* Microsoft ADO **34515971**:
* CSP **CS00012419125**

#### How I did it
Update config.bcm

#### How to verify it
The change is verified by running PFCWD test on a physical testbed.

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202505

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->
Set `sai_stats_support_mask` to `0x800` for Moby HWSKUs.

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
@mssonicbld mssonicbld mentioned this pull request Sep 26, 2025
Merged
9 tasks
mssonicbld added a commit that referenced this pull request Sep 26, 2025
@mssonicbld
Update sai_stats_support_mask for Moby hwsku to remove PFC pause fro…
787afd2 
…m port counter (#24122)

<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "fixes #xxxx", or
 "closes #xxxx" or "resolves #xxxx"

 Please provide the following information:
-->
#### Why I did it
This PR is to set `sai_stats_support_mask` to `0x800` for Moby HWSKUs. This is a continuation of #23772

##### Work item tracking
* Microsoft ADO **34515971**:
* CSP **CS00012419125**

#### How I did it
Update config.bcm

#### How to verify it
The change is verified by running PFCWD test on a physical testbed.

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202505

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->
Set `sai_stats_support_mask` to `0x800` for Moby HWSKUs.

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
@r12f
Copy link
Copy Markdown
Contributor

r12f commented Oct 19, 2025

hi @bingwang-ms , do you mind to help pick this change to 202412?

@bingwang-ms bingwang-ms mentioned this pull request Oct 20, 2025
Merged
9 tasks
@bingwang-ms
Copy link
Copy Markdown
Contributor Author

bingwang-ms commented Oct 20, 2025

hi @bingwang-ms , do you mind to help pick this change to 202412?

Sure, PR raised to 202412 branch Azure/sonic-buildimage-msft#1735

r12f pushed a commit to Azure/sonic-buildimage-msft that referenced this pull request Nov 10, 2025
@bingwang-ms
[202412] Update sai_stats_support_mask from 0x80 to 0x880 to remove P…
3d2c568 
…FC pause frames (#1735)

cherry-pick sonic-net/sonic-buildimage#23772

<!--
Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

** Make sure all your commits include a signature generated with `git
commit -s` **

If this is a bug fix, make sure your description includes "fixes #xxxx",
or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it
This PR is to set `sai_stats_support_mask` to `0x880` for a series of
Arista HWSKUs.

##### Work item tracking
- Microsoft ADO **34515971**:
- CSP **CS00012419125**

#### How I did it
Update config.bcm

#### How to verify it
The change is verified by running PFCWD test on a physical testbed.

<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202505

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 202503
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
Set `sai_stats_support_mask` to `0x480` for a series of Arista HWSKUs.

<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
@sdszhang sdszhang mentioned this pull request Nov 23, 2025
Merged
8 tasks
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Dec 4, 2025
@bingwang-ms @FengPan-Frank
Update sai_stats_support_mask from 0x80 to 0x880 to remove PFC pause …
7179b7b 
…from port counter (sonic-net#23772)

Why I did it
This PR is to set sai_stats_support_mask to 0x880 for a series of Arista HWSKUs.

Work item tracking
Microsoft ADO 34515971:
CSP CS00012419125

How I did it
Update config.bcm

How to verify it
The change is verified by running PFCWD test on a physical testbed.

Signed-off-by: Feng Pan <fenpan@microsoft.com>
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Dec 4, 2025
@sdszhang @FengPan-Frank
Update sai_stats_support_mask for Moby hwsku to remove PFC pause from…
300ac6a 
… port counter (sonic-net#24062)

Why I did it
This PR is to set sai_stats_support_mask to 0x800 for Moby HWSKUs. This is a continuation of sonic-net#23772

Work item tracking
Microsoft ADO 34515971:
CSP CS00012419125
How I did it
Update config.bcm

How to verify it
The change is verified by running PFCWD test on a physical testbed.

Signed-off-by: Feng Pan <fenpan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kperumalbfn kperumalbfn kperumalbfn approved these changes

@BYGX-wcr BYGX-wcr BYGX-wcr approved these changes

Assignees

No one assigned

Labels

Approved for msft-202412 Branch Approved for 202505 Branch Cherry Pick Conflict_msft-202412 Included in msft-202412 Branch Included in msft-202503 Branch Included in 202505 Branch Request for msft-202412 Branch Request for msft-202503 Branch Request for 202505 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bingwang-ms @mssonicbld @r12f @kperumalbfn @BYGX-wcr @yejianquan @yxieca