Update cable length between LT2, FT2 and UT2#23686
Merged
kperumalbfn merged 3 commits intosonic-net:masterfrom Oct 31, 2025
Merged
Update cable length between LT2, FT2 and UT2#23686kperumalbfn merged 3 commits intosonic-net:masterfrom
kperumalbfn merged 3 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
added a commit
to Azure/sonic-buildimage-msft
that referenced
this pull request
Aug 13, 2025
Contributor
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for buffer configuration in LT2 (Lower Tier 2) and FT2 (Fabric Tier 2) network topologies by introducing new cable length mappings and corresponding test cases.
- Adds two new device-to-device cable length mappings for
lowerspinerouter_leafrouter(500m) andfabricspinerouter_lowerspinerouter(5m) - Introduces test case
test_buffers_lt2_ft2_render_templateto validate buffer template rendering for two new SKU configurations - Adds extensive test data files including minigraph XML and expected buffer JSON output for validation
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/sonic-config-engine/tests/test_j2files.py | Adds new test method for LT2/FT2 buffer template rendering with two test scenarios |
| files/build_templates/buffers_config.j2 | Extends cable length configuration with two new tier mappings for lower spine and fabric spine routers |
| src/sonic-config-engine/tests/sample_output/py3/buffer-lt2-p32o64.json | New expected output file for P32O64 configuration (1196 lines) |
| src/sonic-config-engine/tests/sample_output/py3/buffer-ft2-p64.json | New expected output file for P64 configuration (864 lines) |
| src/sonic-config-engine/tests/sample-ft2-p64-minigraph.xml | New test input minigraph for FT2 P64 topology (4426 lines) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kperumalbfn
approved these changes
Oct 31, 2025
ashutosh-agrawal
pushed a commit
to AnantKishorSharma/sonic-buildimage
that referenced
this pull request
Nov 30, 2025
Update cable length between LT2, FT2 and UT2
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Dec 4, 2025
Update cable length between LT2, FT2 and UT2 Signed-off-by: Feng Pan <fenpan@microsoft.com>
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-buildimage
that referenced
this pull request
Dec 22, 2025
Update cable length between LT2, FT2 and UT2 Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This PR is to update cable length between LT2/FT2/UT2.
Work item tracking
How I did it
buffers_config.j2How to verify it
The change is verified by rendering buffer template on a physical device.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Update cable length between LT2/FT2/UT2.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)