Skip to content

Add possibility to install debug packages during build.#234

Merged
lguohan merged 3 commits intosonic-net:masterfrom
antonpatenko:master
Feb 4, 2017
Merged

Add possibility to install debug packages during build.#234
lguohan merged 3 commits intosonic-net:masterfrom
antonpatenko:master

Conversation

@antonpatenko
Copy link
Copy Markdown
Contributor

Added SONIC_CONFIG_DEBUG - option in config script, that allows debug packages installation.
List of debug packages is in docker-base.mk.

rules/config Outdated
PASSWORD = YourPaSsWoRd

# SONIC_CONFIG_DEBUG - install debug packages
SONIC_CONFIG_DEBUG = y
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make it disabled by default?

@oleksandrivantsiv
Copy link
Copy Markdown
Collaborator

Please change pull request name to something like:
"Add possibility to install debug packages during build."

@antonpatenko antonpatenko changed the title Enabled common debug packages installation. Add possibility to install debug packages during build. Feb 1, 2017
@lguohan lguohan merged commit 26f4c85 into sonic-net:master Feb 4, 2017
stcheng pushed a commit to stcheng/sonic-buildimage that referenced this pull request Sep 26, 2018
[schema]: Define STATE_VRF_TABLE_NAME (sonic-net#234)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
lguohan pushed a commit that referenced this pull request Sep 27, 2018
[schema]: Define STATE_VRF_TABLE_NAME (#234)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
[queuestat] add python CLI tool to show queue counters
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
…havior (sonic-net#234)

- Add flexibility to set pop batch size for consumer table. This parameter
  affects the speed of consuming entries from the database. Use a larger
  number will force the consumer to pop out more entries from the database
  on one SPOP operation.
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
Keep port oids in COUNTERS_DB in serializable format
This way client code can reuse sai_deserialize... api
lguohan pushed a commit that referenced this pull request Mar 25, 2021
Fix for vlan-id ACL filter introduced in SONiC 201911 #234

Signed-off-by: Roman Savchuk <romanx.savchuk@intel.com>
judyjoseph added a commit that referenced this pull request Nov 14, 2021
sonic-snmpagent
7e46eb1 [201911][RFC1213]: Initialize lag oid map in reinit_data (#234)
aa98ded CPU Spike because of redundant and flooded keyspace notifis handled (#230)

sonic-swss
bc4e334 [Mux orch] Handle setting unknown mux state (#1984)
bd3630b [tunnel decap] Change tunnel orch order (#1977)
87a673a Fix the option missing in kernel config issue (#1973)
57967a1 [orchagent] Fix group name of port-buffer-drop in flexcounterorch.cpp (#1967)

sonic-utilities
181e8b0 Fix the option missing in kernel config issue (#1888)
21c0cc0 [watermarkstat] Fix for error in processing empty array from couters db (#1810)
7f15755 [chassis][supervisor][show][interfaces]show interfaces command warning on Supervisor card (#1771)
liat-grozovik pushed a commit that referenced this pull request Jan 19, 2022
c4127c2 [psud] Fix PSU log issue (#235)
07542cb [pmon][xcvrd]xcvrd process show backtrace on the internal port. (#233)
3e432e7 [Y-Cable] Increased unit test coverage of y_cable_helper.py (#229)
7c363f5 [ledd] prevent led crash on recirc port event (#232)
e9ccd82 [sonic-platform-daemons] fix dependency issue on py2 wheels by correcting the path (#234)
2b0acfb [sfp-refactoring] xcvrd: add initial support for CMIS application initialization (#217)
lguohan pushed a commit that referenced this pull request Mar 8, 2022
60f5237 (HEAD, origin/202012) [multi-asic]: Udpate to use SonicDBConfig from swsscommon (#219)
5c0d941 [201911][RFC1213]: Initialize lag oid map in reinit_data (#234)

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
sg893052 pushed a commit to sg893052/sonic-buildimage that referenced this pull request Apr 25, 2022
mihirpat1 pushed a commit to mihirpat1/sonic-buildimage that referenced this pull request Feb 21, 2023
…ting the path (sonic-net#234)

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

Description
During a recent cleanup of py2 wheels the path where dependent wheels are installed has changed.
This PR corrects that issue and gathers the dependency wheels from right path.

Motivation and Context
To make sonic-platform-daemons build pass

How Has This Been Tested?
pipelines need to pass
vivekrnv pushed a commit to vivekrnv/sonic-buildimage that referenced this pull request Apr 28, 2023
)

Current m25p80 spi nor driver does not support ACPI table match.
Configuration done through ACPI tables is not recognized by driver.
Cisco 8000 platform cofigures NOR flash partition information
through APCI table which is not recognized by m25p80.

Added support in m25p80 to perform ACPI table match.

Signed-off-by: Madhava Reddy Siddareddygari <msiddare@cisco.com>
vivekrnv pushed a commit to vivekrnv/sonic-buildimage that referenced this pull request Mar 18, 2024
#### Why I did it
For the DASH scenario, the APP_DB will be optimized by protobuf message for less memory consumption.

#### How I did it
Download the Debian package of protobuf 3.21.12 and create a corresponding rule for building it.
Add a submodule of sonic-dash-api and generated its Debian package which includes C++ library and Python library

#### How to verify it
Check artifacts of Azp that the protobuf-related and dash-api deb packages should be generated.
vivekrnv pushed a commit to vivekrnv/sonic-buildimage that referenced this pull request Mar 18, 2024
mssonicbld added a commit that referenced this pull request May 13, 2024
…lly (#18899)

#### Why I did it
src/sonic-gnmi
```
* adece7c - (HEAD -> master, origin/master, origin/HEAD) Merge pull request #234 from saiarcot895/use-latest-swsscommon (3 days ago) [Saikrishna Arcot]
|\ 
| failure_prs.log 82c57c7 - Merge branch 'master' into use-latest-swsscommon (4 days ago) [Saikrishna Arcot]
| |\ 
| |/ 
|/| 
* | d442e7a - Fix memory leak in unit test (#235) (4 days ago) [Hua Liu]
| failure_prs.log ec15a40 - Use the latest libswsscommon artifacts from the repo (4 days ago) [Saikrishna Arcot]
|/ 
* d16d1ca - Fix mixed_db_client ZMQ memory leak. (#232) (6 days ago) [Hua Liu]
* abe3ec0 - Merge pull request #227 from liuh-80/dev/liuh/fix_zmq_memory_leak (6 days ago) [Hua Liu]
* 7949eff - Fix indent issue (6 days ago) [liuh-80]
* 50c6c6d - Merge remote-tracking branch 'origin' into dev/liuh/fix_zmq_memory_leak (6 days ago) [liuh-80]
* 43b6fe5 - Improve code (6 days ago) [liuh-80]
* 709be76 - Fix ZMQ memory leak (7 days ago) [liuh-80]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
[code sync] Merge code from sonic-net/sonic-buildimage:202205 to 202205
mssonicbld added a commit that referenced this pull request Jun 21, 2025
…utomatically (#22660)

#### Why I did it
src/sonic-host-services
```
* 0206da1 - (HEAD -> 202505, origin/202505) Revert "[featured] fix non existing feature start (#234)" (#273) (51 minutes ago) [mssonicbld]
* d4d624e - Add iptables rules to drop all bgp packets destined for loopback1 IP addresses in dual ToR (#269) (10 days ago) [mssonicbld]
* 93db579 - Fix PyGObject required version (#265) (2 weeks ago) [mssonicbld]
* 112acad - [build] Update Azure pipeline to use Ubuntu 24.04 image (#266) (2 weeks ago) [mssonicbld]
* 1ee792e - Implement Download and Delete For File Service (#242) (5 weeks ago) [Dawei Huang]
* 00393e3 - [kdump-config] Update kdump default config with pre-defined value in /proc/cmdline (installer.conf) (#237) (7 weeks ago) [Marty Y. Lok]
* d028745 - [Radius] Add require_message_authenticator option to fix BlastRadius issue. (#172) (7 weeks ago) [Julian Chang]
* 8237b5d - Monitor rsyslog feature flag change and update rsyslog config by restart rsyslog-config service (#245) (7 weeks ago) [Hua Liu]
* 55cee71 - Improve Detection Logic for HALT Command in is_halt_command_running() (#247) (8 weeks ago) [Vasundhara Volam]
* 29b8be8 - [featured] fix non existing feature start (#234) (3 months ago) [Stepan Blyshchak]
* fe90cb1 - Adding support for filtering by destination IP and/or incoming interface to caclmgrd. (#195) (3 months ago) [nyanto]
* 6006e05 - caclmgrd interface rules patch 1 (#197) (3 months ago) [Nanma Purushotam]
* 3ba0c59 - Pin PyGObject to 3.50.0 (#228) (3 months ago) [cpackham-atlnz]
* 5445cf6 - Radius Access request to use configured src interface (#230) (3 months ago) [lakshmi-nexthop]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Jun 22, 2025
…utomatically (#22160)

#### Why I did it
src/sonic-host-services
```
* aa971f6 - (HEAD -> master, origin/master, origin/HEAD) Revert "[featured] fix non existing feature start (#234)" (#272) (29 hours ago) [Qi Luo]
* 04e49f8 - Add iptables rules to drop all bgp packets destined for loopback1 IP addresses in dual ToR (#262) (11 days ago) [Yawen]
* 727e21b - [Caclmgrd]Fix key error issue about acl_source_ip_map (#268) (11 days ago) [Changrong Wu]
* 4cb6b97 - Restart caclmgrd whenever catch exception in child thread or in main thread (#194) (13 days ago) [Zhaohui Sun]
* d7842aa - config_db should not mandate True and False for featured (#252) (2 weeks ago) [Brad House - NextHop]
* 70de4d1 - Fix PyGObject required version (#264) (3 weeks ago) [Qi Luo]
* 953816b - Modify cacl rules to allow incoming packets to dash-ha (#256) (3 weeks ago) [yue-fred-gao]
* 5460c29 - Improve reboot status tracking and add reboot count & method to status (#259) (3 weeks ago) [Vasundhara Volam]
* e46e36e - Update ubuntu version in azure pipeline (#260) (4 weeks ago) [Vasundhara Volam]
* 23b81f9 - Fix reboot without message (#250) (4 weeks ago) [jkmar]
* 1ee792e - Implement Download and Delete For File Service (#242) (5 weeks ago) [Dawei Huang]
* 00393e3 - [kdump-config] Update kdump default config with pre-defined value in /proc/cmdline (installer.conf) (#237) (7 weeks ago) [Marty Y. Lok]
* d028745 - [Radius] Add require_message_authenticator option to fix BlastRadius issue. (#172) (7 weeks ago) [Julian Chang]
* 8237b5d - Monitor rsyslog feature flag change and update rsyslog config by restart rsyslog-config service (#245) (8 weeks ago) [Hua Liu]
* 55cee71 - Improve Detection Logic for HALT Command in is_halt_command_running() (#247) (8 weeks ago) [Vasundhara Volam]
* 29b8be8 - [featured] fix non existing feature start (#234) (3 months ago) [Stepan Blyshchak]
* fe90cb1 - Adding support for filtering by destination IP and/or incoming interface to caclmgrd. (#195) (3 months ago) [nyanto]
* 6006e05 - caclmgrd interface rules patch 1 (#197) (3 months ago) [Nanma Purushotam]
* 3ba0c59 - Pin PyGObject to 3.50.0 (#228) (3 months ago) [cpackham-atlnz]
* 5445cf6 - Radius Access request to use configured src interface (#230) (3 months ago) [lakshmi-nexthop]
```
#### How I did it
#### How to verify it
#### Description for the changelog
jianyuewu pushed a commit to jianyuewu/sonic-buildimage that referenced this pull request Feb 10, 2026
Fix an issue that when starting a non existing feature and then installing it with sonic-package-manager it won't start.

E.g:

admin@sonic:~$ redis-cli -n 4 hmset 'FEATURE|non-existing' state enabled OK
admin@sonic:~$ sudo zless /var/log/syslog | grep featured 2025 Mar 26 15:19:33.237090 sonic INFO featured: Feature non-existing is enabled and started
With this patch an error is recordded and feature state is not cached:

2025 Mar 26 15:35:32.794640 sonic INFO featured: Running cmd: '['sudo', 'systemctl', 'unmask', 'non-existing.service']'
2025 Mar 26 15:35:33.233685 sonic INFO featured: Output:  , Stderr: Unit non-existing.service does not exist, proceeding anyway.
2025 Mar 26 15:35:33.233743 sonic INFO featured: Running cmd: '['sudo', 'systemctl', 'enable', 'non-existing.service']'
2025 Mar 26 15:35:33.247238 sonic ERR featured: ['sudo', 'systemctl', 'enable', 'non-existing.service'] - failed: return code - 1, output:
2025 Mar 26 15:35:33.247300 sonic ERR featured: Feature 'non-existing.service' failed to be enabled and started
2025 Mar 26 15:35:39.331762 sonic INFO featured: Running cmd: '['sudo', 'systemctl', 'unmask', 'non-existing.service']'
2025 Mar 26 15:35:39.780474 sonic INFO featured: Output:  , Stderr: Unit non-existing.service does not exist, proceeding anyway.
2025 Mar 26 15:35:39.780513 sonic INFO featured: Running cmd: '['sudo', 'systemctl', 'enable', 'non-existing.service']'
2025 Mar 26 15:35:39.795113 sonic ERR featured: ['sudo', 'systemctl', 'enable', 'non-existing.service'] - failed: return code - 1, output:
2025 Mar 26 15:35:39.795153 sonic ERR featured: Feature 'non-existing.service' failed to be enabled and started
Feature will start next time when setting state field in FEATURE table
jianyuewu pushed a commit to jianyuewu/sonic-buildimage that referenced this pull request Feb 10, 2026
…onic-net#272)

This reverts commit 29b8be8.

Because it blocks submodule update in sonic-buildimage repo.
The build and test are verified in a draft PR sonic-net#23027.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants