Refine sonic-slave docker image: add entry point#226
Closed
qiluo-msft wants to merge 1 commit intosonic-net:masterfrom
qiluo-msft:github_master
Closed
Refine sonic-slave docker image: add entry point#226qiluo-msft wants to merge 1 commit intosonic-net:masterfrom qiluo-msft:github_master
qiluo-msft wants to merge 1 commit intosonic-net:masterfrom
qiluo-msft:github_master
Conversation
sonic-slave/Dockerfile
Outdated
Collaborator
There was a problem hiding this comment.
Does it have some particular purpose?
Because the actual entry point is usually make command
Collaborator
Author
There was a problem hiding this comment.
In our use case on https://sonic-jenkins.westus.cloudapp.azure.com/, the 'docker inspect' shows as below.
"Cmd": [
"sudo",
"/usr/sbin/sshd",
"-D"
],
"Image": "local/sonic-slave",
"Volumes": null,
"WorkingDir": "",
"Entrypoint": null,
It indicates there is no ENTRYPOINT set. And Jenkins run the container with a sshd command. So the overall effect is a sudo process started with PID=1 in the container. This will introduce a PID 1 zombie reaping problem, which finally fails the command 'service docker stop' inside the container.
BTW, there is a good reference table shows the behaviors of ENTRYPOINT and CMD.
b9ca7e2 to
42ae02b
Compare
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 13, 2021
Update sonic-snmpagent submodule to pick up new commits: 21d7d97 2021-07-12 Fix: SonicV2Connector behavior change: get_all will return empty dict if (#226) 0813b42 2021-07-12 Entries under .1.3.6.1.2.1.31.1.1.1.18 OID should return the "description" field of PORT_TABLE entries in APPL_DB or CONFIG_DB. (#224) 7a78703 2021-07-08 Install dotnet core to fix python gcov warning for code covery color bar showing (#215) e0f36a5 2021-06-30 [multi-asic]: Udpate to use SonicDBConfig from swsscommon (#219) 266bd15 2021-06-10 Restored snmp vlan support per RFC1213 and added the missing support for RFC2863 (#218)
qiluo-msft
added a commit
that referenced
this pull request
Jul 14, 2021
Includes below commits ``` 946e5cf 2021-07-12 | Fix: SonicV2Connector behavior change: get_all will return empty dict if (#226) [Qi Luo] ```
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Update sonic-snmpagent submodule to pick up new commits: 21d7d97 2021-07-12 Fix: SonicV2Connector behavior change: get_all will return empty dict if (sonic-net#226) 0813b42 2021-07-12 Entries under .1.3.6.1.2.1.31.1.1.1.18 OID should return the "description" field of PORT_TABLE entries in APPL_DB or CONFIG_DB. (sonic-net#224) 7a78703 2021-07-08 Install dotnet core to fix python gcov warning for code covery color bar showing (sonic-net#215) e0f36a5 2021-06-30 [multi-asic]: Udpate to use SonicDBConfig from swsscommon (sonic-net#219) 266bd15 2021-06-10 Restored snmp vlan support per RFC1213 and added the missing support for RFC2863 (sonic-net#218)
judyjoseph
added a commit
that referenced
this pull request
Oct 14, 2021
027dffe Fix: SonicV2Connector behavior change: get_all will return empty dict if (#226)
vdahiya12
added a commit
to vdahiya12/sonic-buildimage
that referenced
this pull request
Oct 27, 2021
bf7214c (HEAD -> 202012, origin/202012) [y_cable] add support for manual/standby mode in xcvrd for muxcable; fix download firmware version retrieval logic while download firmware in progress (sonic-net#220) fc6a41e (HEAD -> 202012, origin/202012) Fix typo in the simulated y_cable driver (sonic-net#226) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
5 tasks
vdahiya12
added a commit
that referenced
this pull request
Oct 27, 2021
…ate (#9081) bf7214c (HEAD -> 202012, origin/202012) [y_cable] add support for manual/standby mode in xcvrd for muxcable; fix download firmware version retrieval logic while download firmware in progress (#220) fc6a41e (HEAD -> 202012, origin/202012) Fix typo in the simulated y_cable driver (#226) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Nov 16, 2021
c8eceec 400zr initial support (#228) ef55364 SSD Health: Retrieve SSD health and temperature values from generic SSD info (#229) 26c8346 Fix cmis cable length issue (#225) 671927d Fix typo in the simulated y_cable driver (#226) 51a9aca [sfp-refactor] Add initial support for CMIS in sonic_xcvr (#220) Signed-off-by: Prince George <prgeor@microsoft.com>
SuvarnaMeenakshi
pushed a commit
to SuvarnaMeenakshi/sonic-buildimage
that referenced
this pull request
Mar 16, 2022
… if (sonic-net#226) the hash does not exist in Redis - What I did Fixes sonic-net#8140 ref: swsssdk implementation returns None, and the library will be deprecated libswsscommon implementation returns empty dict - How I did it Relax the condition check to accept both representations - How to verify it Unit test Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
sg893052
pushed a commit
to sg893052/sonic-buildimage
that referenced
this pull request
Apr 25, 2022
Additional watermark counters
6 tasks
snider-nokia
pushed a commit
to snider-nokia/sonic-buildimage
that referenced
this pull request
Apr 6, 2023
PR sonic-net#221 added retry logic to the simualted y_cable driver and introduced typos. This change is to fix the typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
tshalvi
pushed a commit
to tshalvi/sonic-buildimage
that referenced
this pull request
Aug 25, 2025
…AD automatically (sonic-net#1522) #### Why I did it src/sonic-utilities ``` * 3cb0eb24 - (HEAD -> 202412, origin/202412) [202412][reload] stop timers on reload (sonic-net#226) (3 minutes ago) [Stepan Blyshchak] ``` #### How I did it #### How to verify it #### Description for the changelog
vmittal-msft
pushed a commit
to vmittal-msft/sonic-buildimage
that referenced
this pull request
Oct 20, 2025
…AD automatically (sonic-net#1525) #### Why I did it src/sonic-utilities ``` * 47475ea8 - (HEAD -> 202503, origin/202503) Merge pull request sonic-net#231 from mssonicbld/sonicbld/202503-merge (23 hours ago) [mssonicbld] * d3f1a5d9 - Merge branch '202412' of https://github.com/Azure/sonic-utilities.msft into 202503 (23 hours ago) [Sonic Automation] * 3cb0eb24 - (origin/202412) [202412][reload] stop timers on reload (sonic-net#226) (31 hours ago) [Stepan Blyshchak] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.