Skip to content

Ported the fix https://github.com/FRRouting/frr/pull/18601 from FRR community#22408

Merged
yxieca merged 1 commit intosonic-net:masterfrom
sudhanshukumar22:mgmt_corrupted_candidate_ds
Jun 17, 2025
Merged

Ported the fix https://github.com/FRRouting/frr/pull/18601 from FRR community#22408
yxieca merged 1 commit intosonic-net:masterfrom
sudhanshukumar22:mgmt_corrupted_candidate_ds

Conversation

@sudhanshukumar22
Copy link
Copy Markdown
Contributor

@sudhanshukumar22 sudhanshukumar22 commented Apr 22, 2025

Ported the fix FRRouting/frr#18601 from FRR community

Tested using static routes, save and reboot.
K>* 0.0.0.0/0 [0/0] via 10.59.128.1, eth0, 00:03:58
L * 1.1.1.1/32 is directly connected, Loopback0, 00:03:52
C>* 1.1.1.1/32 is directly connected, Loopback0, 00:03:52
C>* 10.59.128.0/20 is directly connected, eth0, 00:03:58
L> 10.59.142.159/32 is directly connected, eth0, 00:03:58
C>* 11.1.0.0/16 is directly connected, vsh0, 00:03:58
L> 11.1.22.238/32 is directly connected, vsh0, 00:03:58
C>* 20.1.1.0/24 is directly connected, Ethernet0, 00:02:22
L> 20.1.1.2/32 is directly connected, Ethernet0, 00:02:22
S>* 40.1.1.1/32 [1/0] is directly connected, Ethernet0, weight 1, 00:00:16
S>* 40.1.1.2/32 [1/0] is directly connected, Ethernet0, weight 1, 00:00:02

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

FRR 10.0.1

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 22, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 22, 2025

Azure Pipelines successfully started running 1 pipeline(s).

yxieca
yxieca previously approved these changes Apr 22, 2025
View reviewed changes
@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented Apr 23, 2025

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 23, 2025

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented Apr 23, 2025

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 23, 2025

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented Apr 29, 2025

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 29, 2025

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 29, 2025

Azure Pipelines successfully started running 1 pipeline(s).

lipxu
lipxu approved these changes Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@lipxu lipxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and verified the internal 202411 image with the PR. No issues.
Verify case:
1: Run the previous test_frr.py script, 50 iterations, no issue found.
2: Repeat running the script bgp/test_traffic_shift.py for more than 100 iterations, no issue found.
3: Repeat loading config from minigraph with TSA for more than 300 iterations, no issue found.

@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented May 2, 2025

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented May 2, 2025

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 2, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented May 5, 2025

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented May 5, 2025

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 5, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented May 5, 2025

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented May 5, 2025

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 5, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented May 7, 2025

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented May 7, 2025

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sudhanshukumar22 sudhanshukumar22 force-pushed the mgmt_corrupted_candidate_ds branch from ea7d969 to d60c5d8 Compare May 14, 2025 09:41
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented May 14, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 14, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented Jun 12, 2025

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 12, 2025

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 12, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented Jun 16, 2025

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 16, 2025

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 16, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@dgsudharsan
Copy link
Copy Markdown
Collaborator

dgsudharsan commented Jun 16, 2025

@yxieca @StormLiangMS @prsunny Can we merge this fix?

@yxieca yxieca merged commit b9f3471 into sonic-net:master Jun 17, 2025
18 checks passed
@dgsudharsan dgsudharsan mentioned this pull request Jun 17, 2025
Merged
9 tasks
@mssonicbld mssonicbld mentioned this pull request Jun 18, 2025
Merged
9 tasks
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 18, 2025

Cherry-pick PR to 202505: #23021

@dgsudharsan dgsudharsan mentioned this pull request Aug 6, 2025
Open
@r12f r12f mentioned this pull request Sep 27, 2025
Merged
r12f added a commit to Azure/sonic-buildimage-msft that referenced this pull request Oct 1, 2025
@r12f @sudhanshukumar22
[202412][PR:22408] Ported the fix FRRouting/frr#18601 from FRR commun…
1dd6181 
…ity (#1675)

Sync PR #22408 from sonic-net/sonic-buildimage to 202412.
Original PR: sonic-net/sonic-buildimage#22408

Co-authored-by: sudhanshukumar22 <51457531+sudhanshukumar22@users.noreply.github.com>
r12f added a commit to Azure/sonic-buildimage-msft that referenced this pull request Oct 26, 2025
@r12f @sudhanshukumar22
[202412][PR:22408] Ported the fix FRRouting/frr#18601 from FRR commun…
97d5937 
…ity (#1675)

Sync PR #22408 from sonic-net/sonic-buildimage to 202412.
Original PR: sonic-net/sonic-buildimage#22408

Co-authored-by: sudhanshukumar22 <51457531+sudhanshukumar22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgsudharsan dgsudharsan dgsudharsan approved these changes

@yxieca yxieca yxieca approved these changes

@lipxu lipxu lipxu approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees

No one assigned

Labels

Approved for msft-202412 Branch Approved for 202505 Branch FRR 🚥 Included in msft-202412 Branch Included in 202505 Branch Request for msft-202412 Branch Request for 202505 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sudhanshukumar22 @mssonicbld @dgsudharsan @yxieca @lipxu @r12f @yejianquan