Fix debug package variables for syncd#18319
Merged
yxieca merged 2 commits intosonic-net:masterfrom Mar 19, 2024
Merged
Conversation
PR sonic-net#16072 renamed the debug package variables from `*_DBG` to `*_DBGSYM`, since the package names had changed. However, the references weren't updated. Since all the other debug packages (including ones that are named `*-dbgsym`) use `*_DBG`, just use that here as well. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Contributor
|
@saiarcot895 |
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Contributor
Author
|
@k-v1 fixed, thanks! |
k-v1
approved these changes
Mar 12, 2024
Collaborator
|
@yxieca @saiarcot895 This PR is important without which we are missing debug symbols with ASAN. Can you please prioritize this? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 19, 2024
* Fix debug package variables for syncd PR sonic-net#16072 renamed the debug package variables from `*_DBG` to `*_DBGSYM`, since the package names had changed. However, the references weren't updated. Since all the other debug packages (including ones that are named `*-dbgsym`) use `*_DBG`, just use that here as well. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Update sairedis.mk as well Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> --------- Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Collaborator
|
Cherry-pick PR to 202311: #18394 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Fix debug package variables for syncd PR #16072 renamed the debug package variables from `*_DBG` to `*_DBGSYM`, since the package names had changed. However, the references weren't updated. Since all the other debug packages (including ones that are named `*-dbgsym`) use `*_DBG`, just use that here as well. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Update sairedis.mk as well Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> --------- Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
PR #16072 renamed the debug package variables from
*_DBGto*_DBGSYM, since the package names had changed. However, the references weren't updated. Since all the other debug packages (including ones that are named*-dbgsym) use*_DBG, just use that here as well.Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)