[Mellanox] Support DSCP remapping in Dual-ToR topo for SN4700-O8V48, update buffers for t0#18293
Merged
yxieca merged 2 commits intosonic-net:masterfrom Mar 18, 2024
Merged
Conversation
Closed
11 tasks
Collaborator
|
@bingwang-ms to check |
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 18293 in repo sonic-net/sonic-buildimage |
Contributor
|
For this specific HWSKU, the change looks good to me. For the Dual-ToR topo, the current plan is to use HWSKU Mellanox-SN4700-V64. Are you going to define the topo and buffer template as well? |
bingwang-ms
approved these changes
Mar 12, 2024
…update buffers for t0 Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
…update buffers for t0 (fixes after recalculation) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
aaa97b8 to
af8e46b
Compare
Contributor
|
@yxieca Can you please help merge this PR? Another PR will be raised for HWSKU SN4700-V64 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 19, 2024
…update buffers for t0 (sonic-net#18293) * [Mellanox] Support DSCP remapping in Dual-ToR topo for SN4700-O8V48, update buffers for t0 Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> * [Mellanox] Support DSCP remapping in Dual-ToR topo for SN4700-O8V48, update buffers for t0 (fixes after recalculation) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> --------- Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
Collaborator
|
Cherry-pick PR to 202311: #18396 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 20, 2024
…update buffers for t0 (#18293) * [Mellanox] Support DSCP remapping in Dual-ToR topo for SN4700-O8V48, update buffers for t0 Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> * [Mellanox] Support DSCP remapping in Dual-ToR topo for SN4700-O8V48, update buffers for t0 (fixes after recalculation) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> --------- Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
Contributor
Author
|
Reminder regarding cherry-pick this PR to 202305 |
Collaborator
|
@StormLiangMS Can you please cherry-pick for 202305? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 2, 2024
…update buffers for t0 (sonic-net#18293) * [Mellanox] Support DSCP remapping in Dual-ToR topo for SN4700-O8V48, update buffers for t0 Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> * [Mellanox] Support DSCP remapping in Dual-ToR topo for SN4700-O8V48, update buffers for t0 (fixes after recalculation) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> --------- Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
Collaborator
|
Cherry-pick PR to 202305: #19773 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 2, 2024
…update buffers for t0 (#18293) * [Mellanox] Support DSCP remapping in Dual-ToR topo for SN4700-O8V48, update buffers for t0 Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> * [Mellanox] Support DSCP remapping in Dual-ToR topo for SN4700-O8V48, update buffers for t0 (fixes after recalculation) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> --------- Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Need to provide support for SN4700-O8V48 for Dual-ToR.
DSCP remapping is a part of Dual-ToR feature, so need to update HWSKU files to align with requirements
Work item tracking
How I did it
Use QoS config the same as used in 4600C platform that is already supports Dual-ToR
update buffers for T0
How to verify it
Run DSCP remapping test for Dual-ToR
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)