[service-checker] Fix the service-checker issue which is caused by PR 17836#18109
Merged
rlhui merged 1 commit intosonic-net:masterfrom Feb 21, 2024
Merged
[service-checker] Fix the service-checker issue which is caused by PR 17836#18109rlhui merged 1 commit intosonic-net:masterfrom
rlhui merged 1 commit intosonic-net:masterfrom
Conversation
…17836 Signed-off-by: mlok <marty.lok@nokia.com>
Contributor
Author
|
@judyjoseph @abdosi OC tested failed on this service checker on MSFT build image .55. Please review this PR. Thanks. |
abdosi
approved these changes
Feb 20, 2024
Contributor
|
@mlok-nokia : please create PR for 202305 as their is conflict |
Contributor
Author
|
@judyjoseph Are we going to cherry-pick this to 202205 next build? |
Contributor
|
@gechiang pls cherry-pick this PR to 202205 - thanks |
Collaborator
|
picked up in 202205-msft repo: |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Apr 5, 2024
…17836 (sonic-net#18109) PR sonic-net#17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor Signed-off-by: mlok <marty.lok@nokia.com>
Collaborator
|
Cherry-pick PR to 202311: #18582 |
mlok-nokia
added a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
…17836 (sonic-net#18109) PR sonic-net#17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor Signed-off-by: mlok <marty.lok@nokia.com>
Collaborator
|
@yxieca , Who can help review/approve this PR for 202311 branch backport? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
PR #17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor
Work item tracking
How I did it
Added the database-chassis feature entry to container_feature_dict[] to address this issue
How to verify it
On Supervisor, execute the "show system-health summary". No exception error shown
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)