Skip to content

[dhcp_server] Remove dependency in port-name-alias-map.txt.j2#17858

Merged
yxieca merged 3 commits intosonic-net:masterfrom
yaqiangz:master_dhcp_server_port_alias
Jan 22, 2024
Merged

[dhcp_server] Remove dependency in port-name-alias-map.txt.j2#17858
yxieca merged 3 commits intosonic-net:masterfrom
yaqiangz:master_dhcp_server_port_alias

Conversation

@yaqiangz
Copy link
Copy Markdown
Contributor

@yaqiangz yaqiangz commented Jan 19, 2024

Why I did it

Currently dhcp_cfggen gets port map from file port-name-alias-map.txt, which is actually generated refer to CONFIG_DB. It will encounter error when PORTCHANNEL table or PORT table not exist in CONFIG_DB.

Work item tracking
  • Microsoft ADO (number only): 26494259

How I did it

Modify dhcp_cfggen to get port map from CONFIG_DB directly.

How to verify it

  • Build successfully.
  • UTs passed.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@yaqiangz yaqiangz marked this pull request as ready for review January 19, 2024 08:43
@yaqiangz yaqiangz requested a review from lguohan as a code owner January 19, 2024 08:43
@yaqiangz yaqiangz force-pushed the master_dhcp_server_port_alias branch from c031bdd to bd179fa Compare January 19, 2024 09:16
@yaqiangz
Copy link
Copy Markdown
Contributor Author

@yxieca Could you please help to merge this PR?

@yxieca yxieca merged commit 27edaf7 into sonic-net:master Jan 22, 2024
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Feb 2, 2024
…net#17858)

* [dhcp_server] Remove dependency in port-name-alias-map.txt.j2
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202311: #17995

mssonicbld pushed a commit that referenced this pull request Feb 2, 2024
* [dhcp_server] Remove dependency in port-name-alias-map.txt.j2
rajib-dutta1 pushed a commit to rajib-dutta1/sonic-buildimage that referenced this pull request Feb 13, 2024
…net#17858)

* [dhcp_server] Remove dependency in port-name-alias-map.txt.j2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants