[docker-fpm-frr]: Fix build with frr used for routing stack#1728
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jun 23, 2018
Merged
[docker-fpm-frr]: Fix build with frr used for routing stack#1728lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
After commit 832be7b ("[dockers] Prevent apt-get from installing suggested and recommended packages by default (sonic-net#1666)") SONiC fails to build when FRR is used for routing stack (e.g. SONIC_ROUTING_STACK is set to frr in rules/config). To fix issue just replicate changes from docker-fpm-quagga to docker-fpm-frr to make dependencies installed correctly after above change to package installing behaviour. Signed-off-by: Sergey Popovich <sergey.popovich@ordnance.co>
|
|
jleveque
approved these changes
May 18, 2018
Contributor
jleveque
left a comment
There was a problem hiding this comment.
Looks good to me. @rodnymolina: please review and test.
rodnymolina
reviewed
May 24, 2018
Contributor
rodnymolina
left a comment
There was a problem hiding this comment.
Changes look good to me. I'll build an image to triple-check. Will approve tomorrow.
vdahiya12
added a commit
to vdahiya12/sonic-buildimage
that referenced
this pull request
Jul 29, 2021
This PR updates the following commits a9606fb [show] fix show muxcable metrics <port> for sorted output (sonic-net#1731) 7355016 [minigraph][port_config] Use imported config.main and add conditional patch (sonic-net#1728) cc1d6e4 [configlet] Python3 compatible syntax for extracting a key from the dict (sonic-net#1721) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Jul 29, 2021
This PR updates the following commits a9606fb [show] fix show muxcable metrics <port> for sorted output (#1731) 7355016 [minigraph][port_config] Use imported config.main and add conditional patch (#1728) cc1d6e4 [configlet] Python3 compatible syntax for extracting a key from the dict (#1721) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
lguohan
pushed a commit
that referenced
this pull request
Aug 25, 2021
d29a49a [ACL] Match TCP protocol while matching TCP_FLAG (#1854) 2569ad9 Fix sFlow sampling-rate and admin-state (#1728) 8908a8f Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (#1848) b42c2fb [VS Test] Skip flaky tests (#1875) Signed-off-by: bingwang <bingwang@microsoft.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
* Fixed incorrect interface admin-status when 'all' interface is disabled but there are local sampling-rate configurations. Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After commit 832be7b ("[dockers] Prevent apt-get from installing
suggested and recommended packages by default (#1666)") SONiC fails
to build when FRR is used for routing stack (e.g. SONIC_ROUTING_STACK
is set to frr in rules/config).
To fix issue just replicate changes from docker-fpm-quagga to
docker-fpm-frr to make dependencies installed correctly after above
change to package installing behaviour.
Signed-off-by: Sergey Popovich sergey.popovich@ordnance.co