Add YANG model for FABRIC_PORT#15629
Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom Jul 3, 2023
Merged
Conversation
8 tasks
Collaborator
Author
Collaborator
Author
arlakshm
previously approved these changes
Jun 26, 2023
ganglyu
reviewed
Jun 26, 2023
|
|
||
| leaf isolateStatus { | ||
| description "Isolation status of a fabric port"; | ||
| type string { |
Collaborator
Author
There was a problem hiding this comment.
Good suggestion. I will revise it to use type stypes:boolean_type where stypes is sonic-types.
Collaborator
Author
There was a problem hiding this comment.
Done. See latest commit. I'm waiting for the pipeline build to complete to check if any further revisions are needed.
arlakshm
approved these changes
Jun 28, 2023
gechiang
approved these changes
Jul 3, 2023
Collaborator
|
@qiluo-msft can you help merge this PR? |
qiluo-msft
approved these changes
Jul 3, 2023
Collaborator
|
@kenneth-arista , @jfeng-arista , This PR also can not be clean cherry picked tot he azure/sonic-buildimage-msft repo 202205 branch. |
Contributor
|
will do thank you
Jie
…On Thu, Jul 13, 2023 at 5:06 PM gechiang ***@***.***> wrote:
@kenneth-arista <https://github.com/kenneth-arista> , @jfeng-arista
<https://github.com/jfeng-arista> , This PR also can not be clean cherry
picked tot he azure/sonic-buildimage-msft repo 202205 branch.
Can you please raise a PR in the azure/sonic-buildimage-msft repo directly
and tag me to review/merge.
Thanks!
—
Reply to this email directly, view it on GitHub
<#15629 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXO4THVLG2XBF3EVDHSD3CLXQCEQZANCNFSM6AAAAAAZTY735M>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
5 tasks
Contributor
|
@gechiang do we need this to cherry pick to 202211/202305? could we have ADO to track? |
Collaborator
|
@StormLiangMS |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 3, 2023
#### Why I did it Introduce YANG model for FABRIC in CONFIG_DB, which was added in sonic-net#14170. #### How I did it This is a clone of @jfeng-arista's PR sonic-net#14282 to resolve conflicts with upstream changes. #### How to verify it Passing pipeline build is sufficient.
Collaborator
|
Cherry-pick PR to 202305: #16398 |
9 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Sep 3, 2023
#### Why I did it Introduce YANG model for FABRIC in CONFIG_DB, which was added in #14170. #### How I did it This is a clone of @jfeng-arista's PR #14282 to resolve conflicts with upstream changes. #### How to verify it Passing pipeline build is sufficient.
Collaborator
|
Removed request for 202211 due to this is treated as "feature" and not bug fix back port. Same reason as why it was not picked for 202205. |
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
#### Why I did it Introduce YANG model for FABRIC in CONFIG_DB, which was added in sonic-net#14170. #### How I did it This is a clone of @jfeng-arista's PR sonic-net#14282 to resolve conflicts with upstream changes. #### How to verify it Passing pipeline build is sufficient.
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
…or-fabric-monitor Add sonic-net#14390 and sonic-net#15629 to 202205.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Introduce YANG model for FABRIC in CONFIG_DB, which was added in #14170.
How I did it
This is a clone of @jfeng-arista's PR #14282 to resolve conflicts with upstream changes.
How to verify it
Passing pipeline build is sufficient.
Which release branch to backport (provide reason below if selected)