Skip to content

Submodule update for sonic-mgmt-common and sonic-gnmi#15519

Merged
Praveen-Brcm merged 2 commits intosonic-net:masterfrom
sachinholla:subscribe_submod
Jul 6, 2023
Merged

Submodule update for sonic-mgmt-common and sonic-gnmi#15519
Praveen-Brcm merged 2 commits intosonic-net:masterfrom
sachinholla:subscribe_submod

Conversation

@sachinholla
Copy link
Copy Markdown
Contributor

@sachinholla sachinholla commented Jun 16, 2023 •
edited
Loading

Why I did it

Updating submodule references for sonic-mgmt-common and sonic-gnmi together.
Cannot update them individually due to compilation dependency. Automatic submodule update jobs are failing.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Updated submodules to include following commits:

sonic-mgmt-common:

38eef09 Fix memleaks in cvl (#95)
f24fc03 Translib APIs for subscription (#92)

sonic-gnmi:

01fe667 Merge pull request #134 from FengPan-Frank/fenpan_dialout_rename
994c69c Rename --enable-dialout option into ENABLE_DIALOUT to follow the convention.
a9126da Update makefile to support armhf (#132)
0d80c0d prevent potential panic: return immediately if there exists error (#113)
3c0fca3 Merge pull request #131 from FengPan-Frank/fenpan_dialout
c3d3266 Add build flag into gnmi as --enable-dialout.
fd78c42 add semgrep (#126)
214fa1c TranslClient: Use new translib subscription APIs (#122)
87d8eb3 TranslClient: use PathValidator to sanitize the request paths (#112)

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@sachinholla sachinholla requested a review from lguohan as a code owner June 16, 2023 23:58
@adyeung adyeung requested a review from qiluo-msft June 21, 2023 19:03
@sachinholla sachinholla force-pushed the subscribe_submod branch 2 times, most recently from c76d947 to 1ebb1e6 Compare July 5, 2023 16:36
@adyeung
Copy link
Copy Markdown
Collaborator

adyeung commented Jul 5, 2023

@lguohan @qiluo-msft Submitter will rebase to sync the branch, if you don't have any concerns about this change, I will request repo maintainer to merge

@qiluo-msft
Copy link
Copy Markdown
Collaborator

qiluo-msft commented Jul 5, 2023

Could you added into PR description the commits included by submodule moving?

@Praveen-Brcm Praveen-Brcm merged commit 39cb254 into sonic-net:master Jul 6, 2023
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
@sachinholla @sonic-otn
Submodule update for sonic-mgmt-common and sonic-gnmi (sonic-net#15519)
ac4f9d9
lixiaoyuner pushed a commit to lixiaoyuner/sonic-buildimage that referenced this pull request Feb 6, 2024
@yejianquan
Merged PR 8419167: Fix master merge conflict
ae6fe5d 
Related work items: sonic-net#94, sonic-net#13789, sonic-net#14149, sonic-net#14515, sonic-net#14788, sonic-net#14922, sonic-net#14933, sonic-net#15284, sonic-net#15383, sonic-net#15464, sonic-net#15519, sonic-net#15521, sonic-net#15575, sonic-net#15636, sonic-net#15652, sonic-net#15684, sonic-net#15708, sonic-net#15725, sonic-net#15739, sonic-net#15755, sonic-net#15756, sonic-net#15757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@anand-kumar-subramanian anand-kumar-subramanian anand-kumar-subramanian approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sachinholla @adyeung @qiluo-msft @anand-kumar-subramanian @Praveen-Brcm