[mlnx-ffb.sh] Update issu-version location#14925
Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom Jun 15, 2023
Merged
[mlnx-ffb.sh] Update issu-version location#14925qiluo-msft merged 4 commits intosonic-net:masterfrom
qiluo-msft merged 4 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
This was referenced May 3, 2023
volodymyrsamotiy
approved these changes
May 15, 2023
Contributor
|
The change LGTM. However, the description says that the change has been tested for 201911 to 202211 Since this change is to master, I think the test should be done for all eligible base branches to master as target. |
Contributor
|
Why is this change not needed on 202205? |
Collaborator
it is needed this is why there is an ask to backport it. |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
@vaibhavhd updated the test upgrade matrix in description |
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vaibhavhd
approved these changes
Jun 12, 2023
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Jun 13, 2023
| mkdir -p "${FS_MOUNTPOINT}" | ||
| mount -t squashfs "${FS_PATH}" "${FS_MOUNTPOINT}" || { | ||
| >&2 echo "Failed to mount next SONiC image" | ||
| ISSU_VERSION_FILE_PATH="/etc/mlnx/issu-version" |
Collaborator
qiluo-msft
approved these changes
Jun 15, 2023
Contributor
|
MSFT ADO: 24417508 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 29, 2023
#### Why I did it ISSU version check fails due to inability to mount squashfs from 202211 on 201911 #### How I did it Put ISSU version file under platform directory #### How to verify it Warm-upgrade matrix: - 201911 (with sonic-net#14928) to master - 201911 (with sonic-net#14928) to 202211 - 202012 (with sonic-net#14927) to master - 202205 (with this change cherry-picked) to master
Collaborator
|
Cherry-pick PR to 202205: #15673 |
10 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 29, 2023
#### Why I did it ISSU version check fails due to inability to mount squashfs from 202211 on 201911 #### How I did it Put ISSU version file under platform directory #### How to verify it Warm-upgrade matrix: - 201911 (with sonic-net#14928) to master - 201911 (with sonic-net#14928) to 202211 - 202012 (with sonic-net#14927) to master - 202205 (with this change cherry-picked) to master
Collaborator
|
Cherry-pick PR to 202211: #15674 |
10 tasks
mssonicbld
added a commit
that referenced
this pull request
Jun 30, 2023
yxieca
pushed a commit
that referenced
this pull request
Jun 30, 2023
#### Why I did it ISSU version check fails due to inability to mount squashfs from 202211 on 201911 #### How I did it Put ISSU version file under platform directory #### How to verify it Warm-upgrade matrix: - 201911 (with #14928) to master - 201911 (with #14928) to 202211 - 202012 (with #14927) to master - 202205 (with this change cherry-picked) to master Co-authored-by: Stepan Blyshchak <38952541+stepanblyschak@users.noreply.github.com>
Collaborator
|
@stepanblyschak PR conflicts with 202305 branch |
Contributor
|
@stepanblyschak @liat-grozovik cherry-pick failure, need separate PR to 202305. |
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
#### Why I did it ISSU version check fails due to inability to mount squashfs from 202211 on 201911 #### How I did it Put ISSU version file under platform directory #### How to verify it Warm-upgrade matrix: - 201911 (with sonic-net#14928) to master - 201911 (with sonic-net#14928) to 202211 - 202012 (with sonic-net#14927) to master - 202205 (with this change cherry-picked) to master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
ISSU version check fails due to inability to mount squashfs from 202211 on 201911
Work item tracking
How I did it
Put ISSU version file under platform directory
How to verify it
Warm-upgrade matrix:
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)