[device]: Add a new supported device, Delta-ag5648 by nealtai · Pull Request #1470 · sonic-net/sonic-buildimage

nealtai · 2018-03-08T04:53:32Z

[device]: Add a new supported platform & device, Delta-ag5648
CPU : Intel Rangeley C2538
Swich ASIC: Broadcom Tomahawk BCM56967
Ports : 48x25G + 6x100G
Switch SKU : Delta-ag5648

CPU : Intel Rangeley C2538 Swich ASIC: Broadcom Tomahawk BCM56967 Ports : 48x25G + 6x100G Switch SKU : Delta-ag5648 Signed-off-by: neal tai <neal.tai@deltaww.com>

lguohan · 2018-03-09T23:50:05Z

remove all *.cmd files, they are build aux files

Refers to: platform/broadcom/sonic-platform-modules-delta/ag5648/modules/.built-in.o.cmd:2 in 12caf67. [](commit_id = 12caf67, deletion_comment = False)

lguohan · 2018-03-09T23:51:23Z

platform/broadcom/sonic-platform-modules-delta/debian/files

@@ -1,2 +1,3 @@
 platform-modules-ag9032v1_1.1_amd64.deb main extra
 platform-modules-ag9064_1.1_amd64.deb main extra
+platform-modules-ag5648_1.1_amd64.deb main extra


this is auto-generated file, please do not check-in this file.

can you remove this file?

In #1481 . I removed it & all *.cmd files

why create a new PR? why not update this PR, it is easier for me to check if all comments are addressed. When you move to a new PR, there is no history, no context, for me it is a completely new PR. I have to start from scratch to review.

OK! I will update on this PR.

lguohan · 2018-03-09T23:55:00Z

platform/broadcom/sonic-platform-modules-delta/ag5648/scripts/led_control

+FAN1_EEPROM="-y 3 0x51 0x0a"
+FAN2_EEPROM="-y 3 0x52 0x0a"
+FAN3_EEPROM="-y 3 0x53 0x0a"
+FAN4_EEPROM="-y 3 0x54 0x0a"


I do not know what this means. Instead of using i2cget to get these values, these values should be exposed by platform drivers to operate.

Get the eeprom of fantrays to check fan trays insert or not.

lguohan · 2018-03-09T23:56:47Z

platform/broadcom/sonic-platform-modules-delta/ag5648/scripts/led_control

+
+while true
+do
+    platformstatus


what if one of the fantray is not inserted? will your script break?

Script will not be break. It changes the color of the led.

lguohan · 2018-03-10T00:02:22Z

platform/broadcom/sonic-platform-modules-delta/ag5648/modules/dni_emc2305.c

+
+MODULE_AUTHOR("Neal Tai<neal.tai@deltaww.com>");
+MODULE_DESCRIPTION("SMSC EMC2305 fan controller driver");
+MODULE_LICENSE("GPL");


what is the difference between this one and the one for 9032 platform. i saw one there too.

There are four fan trays on ag5648 & five on ag9032v1.

in terms of the driver, they should be the same. can we re-use the existing driver?

OK! I will use the existing driver.

nealtai · 2018-03-12T01:59:33Z

Thanks for reminding me.
I will check all the files and have the PR again.

Delete the auto-generated file.

remove the files under ag5648/modules Signed-off-by: neal tai <neal.tai@deltaww.com>

lguohan · 2018-03-19T05:44:45Z

will you reuse the dni_emc2305.c file already in your rep?

nealtai · 2018-03-19T08:35:44Z

Common dni_emc2305.c file is not ready in my rep
because I'm doing the final check. I will reuse it & commit later.
Thanks

1. Use the common driver dni_emc2305.c ag9032v1 device drivers 1. Move dni_emc2305.c to be the common driver 2. Remove at24.c Signed-off-by: neal tai <neal.tai@deltaww.com>

nealtai · 2018-03-20T06:28:29Z

Hi @lguohan
I reuse the dni_emc2305.c in my rep now.
Please check it.

Thanks again.
Neal.

swss: * c712c24 2021-03-04 | Update StateDB with error if state change failed, Update APP_DB in all state chg req (sonic-net#1662) (HEAD -> 202012) [Prince Sunny] utilities: * 9a9bff4 2021-03-03 | [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475) (HEAD -> 202012) [Danny Allen] * d1e7d4e 2021-03-04 | [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470) [Junchao-Mellanox] * a1df1b4 2021-03-03 | [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469) [Danny Allen] * bab4a23 2021-03-03 | [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465) [Lawrence Lee] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

swss: * c712c24 2021-03-04 | Update StateDB with error if state change failed, Update APP_DB in all state chg req (#1662) (HEAD -> 202012) [Prince Sunny] utilities: * 9a9bff4 2021-03-03 | [acl] Expand VLAN into VLAN members when creating an ACL table (#1475) (HEAD -> 202012) [Danny Allen] * d1e7d4e 2021-03-04 | [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (#1470) [Junchao-Mellanox] * a1df1b4 2021-03-03 | [acl-loader] Add support for matching on ICMP and VLAN info (#1469) [Danny Allen] * bab4a23 2021-03-03 | [config reload]: On dual ToR systems, cache ARP and FDB tables (#1465) [Lawrence Lee] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

this PR updates the following commits in sonic-utilities 13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (#1467) f78e7ce [acl-loader] Improve input validation for acl_loader (#1479) 748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (#1368) 64604db [acl] Expand VLAN into VLAN members when creating an ACL table (#1475) 10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (#1465) 10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (#1470) 38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (#1469) e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (#1380) 4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (#1471) dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (#1460) e32b5ac Add soft-reboot reboot type (#1453) 8b3bc18 [reload] Improve reload by using sonic.target. (#1199) 99673bc [reboot] Add platform-specific reboot cause update hook (#1454) 2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (#1445) 1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (#1416) 79ccd03 [show] cli support for show muxcable cableinfo (#1448) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

…0-D40C8S8 (sonic-net#1470) **- What I did** Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 **- How I did it** New SKU Mellanox-SN2700-D40C8S8 will reuse buffer configuration of Mellanox-SN2700-D48C8 **- How to verify it** Run sonic-mgmt qos test and pass

this PR updates the following commits in sonic-utilities 13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (sonic-net#1467) f78e7ce [acl-loader] Improve input validation for acl_loader (sonic-net#1479) 748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (sonic-net#1368) 64604db [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475) 10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465) 10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470) 38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469) e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (sonic-net#1380) 4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (sonic-net#1471) dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460) e32b5ac Add soft-reboot reboot type (sonic-net#1453) 8b3bc18 [reload] Improve reload by using sonic.target. (sonic-net#1199) 99673bc [reboot] Add platform-specific reboot cause update hook (sonic-net#1454) 2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445) 1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (sonic-net#1416) 79ccd03 [show] cli support for show muxcable cableinfo (sonic-net#1448) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

qiluo-msft · 2022-08-29T19:11:16Z

device/delta/x86_64-delta_ag5648-r0/plugins/psuutil.py

+        status = 0
+        try:
+            p = os.popen(self.psu_presence.format(index + Base_bus_number)+ "> /dev/null 2>&1")
+            if p.readline() != None:


The code redirect stderr->stdout->NULL, then nothing will be collected, why check p.readline()?

@nealtai Could you check whether this is a bug?

…tically (#20835) #### Why I did it src/sonic-sairedis ``` * e6ec1424 - (HEAD -> master, origin/master, origin/HEAD) [syncd] Add attribute version check feature (#1470) (14 hours ago) [Kamil Cudnik] * 29a8f86b - [meta] Use metadata to check port notification port_id type (#1469) (2 days ago) [Kamil Cudnik] * d772864e - innovium rename to marvell-teralynx (#1408) (2 days ago) [krismarvell] * 526bca31 - [submodule] Update SAI to lates origin master (#1466) (2 days ago) [Kamil Cudnik] * fc376d50 - [test] Add more testing for NotificationSwitchAsicSdkHealthEvent (#1463) (4 days ago) [Kamil Cudnik] * ed222eca - [submodule] Update SAI to v1.15.1 (#1462) (5 days ago) [Kamil Cudnik] ``` #### How I did it #### How to verify it #### Description for the changelog

…tically (sonic-net#20835) #### Why I did it src/sonic-sairedis ``` * e6ec1424 - (HEAD -> master, origin/master, origin/HEAD) [syncd] Add attribute version check feature (sonic-net#1470) (14 hours ago) [Kamil Cudnik] * 29a8f86b - [meta] Use metadata to check port notification port_id type (sonic-net#1469) (2 days ago) [Kamil Cudnik] * d772864e - innovium rename to marvell-teralynx (sonic-net#1408) (2 days ago) [krismarvell] * 526bca31 - [submodule] Update SAI to lates origin master (sonic-net#1466) (2 days ago) [Kamil Cudnik] * fc376d50 - [test] Add more testing for NotificationSwitchAsicSdkHealthEvent (sonic-net#1463) (4 days ago) [Kamil Cudnik] * ed222eca - [submodule] Update SAI to v1.15.1 (sonic-net#1462) (5 days ago) [Kamil Cudnik] ``` #### How I did it #### How to verify it #### Description for the changelog

[platform]: Add a new supported platform, Delta-ag5648

12caf67

CPU : Intel Rangeley C2538 Swich ASIC: Broadcom Tomahawk BCM56967 Ports : 48x25G + 6x100G Switch SKU : Delta-ag5648 Signed-off-by: neal tai <neal.tai@deltaww.com>

hans-tseng mentioned this pull request Mar 8, 2018

helping to merge the ag5648 broadcom's config #1473

Closed

jleveque approved these changes Mar 9, 2018

View reviewed changes

jleveque added the Enhancement ➕ label Mar 9, 2018

lguohan reviewed Mar 9, 2018

View reviewed changes

lguohan reviewed Mar 10, 2018

View reviewed changes

nealtai closed this Mar 12, 2018

lguohan reopened this Mar 13, 2018

lguohan mentioned this pull request Mar 13, 2018

[device]: Add a new supported device, Delta-ag5648 #1481

Closed

nealtai and others added 2 commits March 14, 2018 16:05

Delete the file

99bb389

Delete the auto-generated file.

[device]: ag5648 remove all *.cmd files.

4f4d49c

remove the files under ag5648/modules Signed-off-by: neal tai <neal.tai@deltaww.com>

[device]: ag5648 device drivers

6822fff

1. Use the common driver dni_emc2305.c ag9032v1 device drivers 1. Move dni_emc2305.c to be the common driver 2. Remove at24.c Signed-off-by: neal tai <neal.tai@deltaww.com>

lguohan approved these changes Mar 20, 2018

View reviewed changes

lguohan merged commit 830e1dd into sonic-net:master Mar 23, 2018

jleveque mentioned this pull request Mar 30, 2018

How could i commit code to SONIC codebase for adding new platform devices? #1553

Closed

yxieca mentioned this pull request Mar 4, 2021

[202012][swss][utilities] advance submodule head #6969

Merged

vdahiya12 mentioned this pull request Mar 9, 2021

[sonic-utilities] submodule update #6992

Merged

4 tasks

qiluo-msft reviewed Aug 29, 2022

View reviewed changes

Conversation

nealtai commented Mar 8, 2018

Uh oh!

lguohan commented Mar 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nealtai Mar 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan Mar 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nealtai commented Mar 12, 2018

Uh oh!

lguohan commented Mar 19, 2018

Uh oh!

nealtai commented Mar 19, 2018

Uh oh!

nealtai commented Mar 20, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nealtai Mar 12, 2018 •

edited

Loading

lguohan Mar 9, 2018 •

edited

Loading