Skip to content

[sflow] Exception handling for if_nametoindex (#11437)#13567

Merged
lguohan merged 1 commit intosonic-net:masterfrom
Gokulnath-Raja:sflow_bug#11437_port_index_mapper_interface_handling
Mar 27, 2023
Merged

[sflow] Exception handling for if_nametoindex (#11437)#13567
lguohan merged 1 commit intosonic-net:masterfrom
Gokulnath-Raja:sflow_bug#11437_port_index_mapper_interface_handling

Conversation

@Gokulnath-Raja
Copy link
Copy Markdown
Contributor

@Gokulnath-Raja Gokulnath-Raja commented Jan 31, 2023

catch system error and log as warning level instead of
error level in case interface was already deleted.

Why I did it

sflow process exited when failed to convert the interface index from interface name

How I did it

Added exception handling code and logged when OSError exception.

How to verify it

Recreated the bug scenario #11437 and ensured that sflow process not exited.

Description for the changelog

catch system error and log as warning level instead of
error level in case interface was already deleted.

Logs
steps :

root@sonic:~# sudo config vlan member del 4094 PortChannel0001
root@sonic:~# sudo config vlan member del 4094 Ethernet2
root@sonic:~# sudo config vlan del 4094
root@sonic:~#

"WARNING sflow#port_index_mapper: no interface with this name" is  seen but no crash is reported

syslogs :


Jan 23 09:17:24.420448 sonic NOTICE swss#orchagent: :- removeVlanMember: Remove member Ethernet2 from VLAN Vlan4094 lid:ffe vmid:27000000000a53
Jan 23 09:17:24.420710 sonic NOTICE swss#orchagent: :- flushFdbEntries: flush key: SAI_OBJECT_TYPE_FDB_FLUSH:oid:0x21000000000000, fields: 3
Jan 23 09:17:24.420847 sonic NOTICE swss#orchagent: :- recordFlushFdbEntries: flush key: SAI_OBJECT_TYPE_FDB_FLUSH:oid:0x21000000000000, fields: 3
Jan 23 09:17:24.426082 sonic NOTICE syncd#syncd: :- processFdbFlush: fdb flush succeeded, updating redis database
Jan 23 09:17:24.426242 sonic NOTICE syncd#syncd: :- processFlushEvent: received a flush port fdb event, portVid = oid:0x3a000000000a52, bvId = oid:0x26000000000a51
Jan 23 09:17:24.426374 sonic NOTICE syncd#syncd: :- processFlushEvent: pattern ASIC_STATE:SAI_OBJECT_TYPE_FDB_ENTRY:*oid:0x26000000000a51*, portStr oid:0x3a000000000a52
Jan 23 09:17:24.427104 sonic NOTICE bgp#fpmsyncd: :- onRouteMsg: RouteTable del msg for route with only one nh on eth0/docker0: fe80::/64 :: eth0
Jan 23 09:17:24.427182 sonic NOTICE bgp#fpmsyncd: :- onRouteMsg: RouteTable del msg for route with only one nh on eth0/docker0: fd00::/80 :: docker0
Jan 23 09:17:24.428502 sonic NOTICE swss#orchagent: :- meta_sai_on_fdb_flush_event_consolidated: processing consolidated fdb flush event of type: SAI_FDB_ENTRY_TYPE_DYNAMIC
Jan 23 09:17:24.429058 sonic NOTICE swss#orchagent: :- meta_sai_on_fdb_flush_event_consolidated: fdb flush took 0.000606 sec
Jan 23 09:17:24.431496 sonic NOTICE swss#orchagent: :- setHostIntfsStripTag: Set SAI_HOSTIF_VLAN_TAG_STRIP to host interface: Ethernet2
Jan 23 09:17:24.431675 sonic NOTICE swss#orchagent: :- flushFdbEntries: flush key: SAI_OBJECT_TYPE_FDB_FLUSH:oid:0x21000000000000, fields: 2
Jan 23 09:17:24.431797 sonic NOTICE swss#orchagent: :- recordFlushFdbEntries: flush key: SAI_OBJECT_TYPE_FDB_FLUSH:oid:0x21000000000000, fields: 2
Jan 23 09:17:24.437009 sonic NOTICE swss#orchagent: :- meta_sai_on_fdb_flush_event_consolidated: processing consolidated fdb flush event of type: SAI_FDB_ENTRY_TYPE_DYNAMIC
Jan 23 09:17:24.437532 sonic NOTICE swss#orchagent: :- meta_sai_on_fdb_flush_event_consolidated: fdb flush took 0.000514 sec
Jan 23 09:17:24.437942 sonic NOTICE syncd#syncd: :- processFdbFlush: fdb flush succeeded, updating redis database
Jan 23 09:17:24.438065 sonic NOTICE syncd#syncd: :- processFlushEvent: received a flush port fdb event, portVid = oid:0x3a000000000a52, bvId = oid:0x0
Jan 23 09:17:24.438173 sonic NOTICE syncd#syncd: :- processFlushEvent: pattern ASIC_STATE:SAI_OBJECT_TYPE_FDB_ENTRY:*, portStr oid:0x3a000000000a52
Jan 23 09:17:24.440348 sonic NOTICE swss#orchagent: :- removeBridgePort: Remove bridge port Ethernet2 from default 1Q bridgeJan 23 09:17:29.782554 sonic NOTICE swss#orchagent: :- removeVlan: VLAN Vlan4094 still has 1 FDB entries
Jan 23 09:17:29.791373 sonic WARNING sflow#port_index_mapper: no interface with this name

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Jan 31, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Gokulnath-Raja (fe46c10)

@Gokulnath-Raja Gokulnath-Raja mentioned this pull request Jan 31, 2023
Open
venkatmahalingam
venkatmahalingam reviewed Jan 31, 2023
View reviewed changes
@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented Feb 2, 2023

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 2, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@Gokulnath-Raja Gokulnath-Raja force-pushed the sflow_bug#11437_port_index_mapper_interface_handling branch from 6bce8c1 to 51381f6 Compare February 8, 2023 10:08
@venkatmahalingam
Copy link
Copy Markdown
Collaborator

venkatmahalingam commented Feb 8, 2023 •
edited
Loading

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 8, 2023

Commenter does not have sufficient privileges for PR 13567 in repo sonic-net/sonic-buildimage

1 similar comment
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 8, 2023

Commenter does not have sufficient privileges for PR 13567 in repo sonic-net/sonic-buildimage

@Gokulnath-Raja
Copy link
Copy Markdown
Contributor Author

Gokulnath-Raja commented Feb 8, 2023

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 8, 2023

Commenter does not have sufficient privileges for PR 13567 in repo sonic-net/sonic-buildimage

@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented Feb 8, 2023

/azp run Azure.sonic-buildimage

@Gokulnath-Raja , you can try "/azpw run Azure.sonic-buildimage"

@Gokulnath-Raja
Copy link
Copy Markdown
Contributor Author

Gokulnath-Raja commented Feb 9, 2023

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Feb 9, 2023

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 9, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@Gokulnath-Raja Gokulnath-Raja force-pushed the sflow_bug#11437_port_index_mapper_interface_handling branch from 51381f6 to 9c43b40 Compare February 14, 2023 09:32
@Gokulnath-Raja
[sflow] Exception handling for if_nametoindex (sonic-net#11437)
fe46c10 
     catch system error and log as warning level instead of
     error level in case interface was already deleted

Signed-off-by: Gokulnath-Raja <Gokulnath_R@dell.com>
@Gokulnath-Raja Gokulnath-Raja force-pushed the sflow_bug#11437_port_index_mapper_interface_handling branch from 9c43b40 to fe46c10 Compare February 14, 2023 09:48
@Gokulnath-Raja
Copy link
Copy Markdown
Contributor Author

Gokulnath-Raja commented Feb 14, 2023

/AzurePipelines run EasyCLA

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 14, 2023

Commenter does not have sufficient privileges for PR 13567 in repo sonic-net/sonic-buildimage

@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented Feb 14, 2023

@Gokulnath-Raja , please sign CLA

@venkatmahalingam venkatmahalingam mentioned this pull request Mar 17, 2023
Open
@venkatmahalingam
Copy link
Copy Markdown
Collaborator

venkatmahalingam commented Mar 17, 2023

@lguohan Can you please review this PR?

@lguohan lguohan merged commit cedc4d9 into sonic-net:master Mar 27, 2023
@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Mar 27, 2023

do we need to pick this to 202205, 202211 older branch?

@Gokulnath-Raja
Copy link
Copy Markdown
Contributor Author

Gokulnath-Raja commented Mar 29, 2023

do we need to pick this to 202205, 202211 older branch?

Raised pull request for 202205 and 202211 branches by cherry picking from master branch.

#14456
#14457

@dgsudharsan dgsudharsan mentioned this pull request May 4, 2023
Merged
lixiaoyuner pushed a commit to lixiaoyuner/sonic-buildimage that referenced this pull request Feb 6, 2024
@yejianquan
Merged PR 7894273: Fix the conflict of sonic-net#14371
95e3f0a 
https://msazure.visualstudio.com/One/_workitems/edit/17813211

Related work items: sonic-net#9216, sonic-net#11437, sonic-net#13507, sonic-net#13512, sonic-net#13567, sonic-net#13972, sonic-net#14351, sonic-net#14371, sonic-net#14375, sonic-net#14401, sonic-net#14407, sonic-net#14408, sonic-net#14427, sonic-net#14428, sonic-net#14439
lixiaoyuner pushed a commit to lixiaoyuner/sonic-buildimage that referenced this pull request Feb 6, 2024
@yejianquan
Merged PR 7915643: Fix the conflict of sonic-net#14371
d79fd1b 
Related work items: sonic-net#9216, sonic-net#11437, sonic-net#13507, sonic-net#13512, sonic-net#13567, sonic-net#13972, sonic-net#14351, sonic-net#14371, sonic-net#14375, sonic-net#14401, sonic-net#14407, sonic-net#14408, sonic-net#14427, sonic-net#14428, sonic-net#14439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@venkatmahalingam venkatmahalingam venkatmahalingam approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees

No one assigned

Labels

Request for 202211 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Gokulnath-Raja @prsunny @venkatmahalingam @mssonicbld @lguohan @dgsudharsan