Create default Vxlan and Vnet configs by prsunny · Pull Request #13409 · sonic-net/sonic-buildimage

prsunny · 2023-01-18T01:24:33Z

Why I did it

Create Vxlan and Vnet default configs as below for certain cases:

"VNET": {
    "Vnet-default": {
        "scope": "default",
        "vni": "8000",
        "vxlan_tunnel": "Tunnel-default"
    }
},
"VXLAN_TUNNEL": {
    "Tunnel-default": {
        "src_ip": "10.1.0.32"
    }
},

MSFT ADO - 24263117

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

prsunny · 2023-01-19T18:26:05Z

src/sonic-config-engine/tests/test_cfggen.py

+    def run_script(self, argument, check_stderr=False, verbose=False, skip_yang_validation=False):
        print('\n    Running sonic-cfggen ' + ' '.join(argument))
-        self.assertTrue(self.yang.validate(argument))
+        if not skip_yang_validation:


Discussed in Yang community (1/19) and proposal is to add the Yang model and remove the skip validation

This is addressed

Could you share the link addressed this issue?

lguohan

generally looks good to me, but let's finalize the plan.

prsunny · 2023-06-14T17:28:13Z

/easycla

src/sonic-config-engine/minigraph.py

mssonicbld · 2023-06-15T16:08:16Z

@prsunny PR conflicts with 202205 branch

* Create default Vxlan and Vnet configs for ToRs with Appliance Resource type

mssonicbld · 2023-06-15T16:08:17Z

Cherry-pick PR to 202211: #15477

* Create default Vxlan and Vnet configs for ToRs with Appliance Resource type

[Sonic-Config-Engine] Re-add the yang validation check accidently removed by #13409

[Sonic-Config-Engine] Re-add the yang validation check accidently removed by sonic-net#13409

mssonicbld · 2023-08-10T09:24:28Z

@prsunny cherry pick PR didn't pass PR checker. Please check!!!
#15477

mssonicbld · 2023-08-10T09:27:38Z

@prsunny cherry pick PR didn't pass PR checker. Please check!!!
#15477

mssonicbld · 2023-08-10T09:32:19Z

@prsunny cherry pick PR didn't pass PR checker. Please check!!!
#15477

* Create default Vxlan and Vnet configs for ToRs with Appliance Resource type

[Sonic-Config-Engine] Re-add the yang validation check accidently removed by sonic-net#13409

prsunny added 2 commits January 18, 2023 01:21

Create default Vxlan and Vnet configs

0964b7a

Update test cases, yang

c3be3e8

prsunny mentioned this pull request Jan 18, 2023

[201911] Create Vxlan and Vnet default configs #13403

Merged

8 tasks

prsunny commented Jan 19, 2023

View reviewed changes

lguohan reviewed Jan 20, 2023

View reviewed changes

Remove yang validation skip

335af54

prsunny added Request for 202205 Branch Request for 202211 Branch Request for 202305 Branch labels Jun 13, 2023

prsunny requested a review from qiluo-msft June 14, 2023 17:29

qiluo-msft reviewed Jun 14, 2023

View reviewed changes

src/sonic-config-engine/minigraph.py Show resolved Hide resolved

qiluo-msft approved these changes Jun 14, 2023

View reviewed changes

prsunny merged commit f75116a into sonic-net:master Jun 14, 2023

prsunny deleted the vxlan_master branch June 14, 2023 23:07

yxieca added Approved for 202205 Branch Approved for 202211 Branch labels Jun 15, 2023

mssonicbld added the Cherry Pick Conflict_202205 label Jun 15, 2023

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 15, 2023

Create default Vxlan and Vnet configs (sonic-net#13409)

e6502ec

* Create default Vxlan and Vnet configs for ToRs with Appliance Resource type

mssonicbld added the Created PR to 202211 Branch label Jun 15, 2023

mssonicbld mentioned this pull request Jun 15, 2023

[action] [PR:13409] Create default Vxlan and Vnet configs #15477

Closed

8 tasks

prsunny mentioned this pull request Jun 15, 2023

[202205] Create default Vxlan and Vnet configs (#13409) #15497

Merged

10 tasks

prsunny added a commit to prsunny/sonic-buildimage that referenced this pull request Jun 15, 2023

Create default Vxlan and Vnet configs (sonic-net#13409)

9425a04

* Create default Vxlan and Vnet configs for ToRs with Appliance Resource type

prsunny mentioned this pull request Jun 15, 2023

Add check for yang validation #15498

Merged

10 tasks

yxieca pushed a commit that referenced this pull request Jun 16, 2023

Create default Vxlan and Vnet configs (#13409) (#15497)

b4dcd1b

* Create default Vxlan and Vnet configs for ToRs with Appliance Resource type

yxieca added the Included in 202205 Branch label Jun 16, 2023

prsunny added a commit that referenced this pull request Jun 16, 2023

Fix a check for yang validation (#15498)

6df7009

[Sonic-Config-Engine] Re-add the yang validation check accidently removed by #13409

StormLiangMS added the Included in 202305 Branch label Jun 23, 2023

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 23, 2023

Fix a check for yang validation (sonic-net#15498)

7154aea

[Sonic-Config-Engine] Re-add the yang validation check accidently removed by sonic-net#13409

mssonicbld mentioned this pull request Jun 23, 2023

[action] [PR:15498] Add check for yang validation #15600

Merged

10 tasks

sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023

Create default Vxlan and Vnet configs (sonic-net#13409)

ed253cb

* Create default Vxlan and Vnet configs for ToRs with Appliance Resource type

sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023

Fix a check for yang validation (sonic-net#15498)

8e97826

[Sonic-Config-Engine] Re-add the yang validation check accidently removed by sonic-net#13409

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create default Vxlan and Vnet configs#13409

Create default Vxlan and Vnet configs#13409
prsunny merged 3 commits intosonic-net:masterfrom
prsunny:vxlan_master

prsunny commented Jan 18, 2023 •

edited

Loading

Uh oh!

prsunny Jan 19, 2023

Uh oh!

prsunny Jun 14, 2023

Uh oh!

qiluo-msft Jun 14, 2023

Uh oh!

lguohan left a comment

Uh oh!

prsunny commented Jun 14, 2023

Uh oh!

Uh oh!

mssonicbld commented Jun 15, 2023

Uh oh!

mssonicbld commented Jun 15, 2023

Uh oh!

mssonicbld commented Aug 10, 2023

Uh oh!

mssonicbld commented Aug 10, 2023

Uh oh!

mssonicbld commented Aug 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

prsunny commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

prsunny Jan 19, 2023

Choose a reason for hiding this comment

Uh oh!

prsunny Jun 14, 2023

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Jun 14, 2023

Choose a reason for hiding this comment

Uh oh!

lguohan left a comment

Choose a reason for hiding this comment

Uh oh!

prsunny commented Jun 14, 2023

Uh oh!

Uh oh!

mssonicbld commented Jun 15, 2023

Uh oh!

mssonicbld commented Jun 15, 2023

Uh oh!

mssonicbld commented Aug 10, 2023

Uh oh!

mssonicbld commented Aug 10, 2023

Uh oh!

mssonicbld commented Aug 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

prsunny commented Jan 18, 2023 •

edited

Loading