[build] Fix isc-dhcp full version in rules.mk by guillaumelambert · Pull Request #13288 · sonic-net/sonic-buildimage

guillaumelambert · 2023-01-06T07:30:49Z

During the build process, a dsc file is retrieved from the URL: http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc

Depending on the DNS resolution, the server reached may respond with a HTTP 404 error code, what stops the build process. In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/ no more lists this DSC file but one with a different format.

The suffix "+deb11u1" is now appended to identify the debian version.

append this suffix to the make file rules of isc-dhcp

Issue #13281

Which release branch to backport (provide reason below if selected)

all using this version of isc-dhcp

Description for the changelog

[build] Fix isc-dhcp full version in rules.mk

A picture of a cute animal (not mandatory but encouraged)

                  .".
                     /  |
                    /  /
                   / ,"
       .-------.--- /
      "._ __.-/ o. o\  
         "   (    Y  )
              )     /
             /     (
            /       Y
        .-"         |
       /  _     \    \ 
      /    `. ". ) /' )
     Y       )( / /(,/
    ,|      /     )
   ( |     /     /
    " \_  (__   (__        [nabis]
        "-._,)--._,)

During the build process, a dsc file is retrieved from the URL: http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc Depending on the DNS resolution, the server reached may respond with a HTTP 404 error code, what stops the build process. In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/ no more lists this DSC file but one with a different format. The suffix "+deb11u1" is now appended to identify the debian version. - append this suffix to the make file rules of isc-dhcp Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>

guillaumelambert · 2023-01-06T07:32:27Z

@collivier @odd22 FYI

saiarcot895 · 2023-01-06T17:44:29Z

Technically, this is a package update, not just a version numbering fix. It's odd, though, that the dsc file for 4.4.1-2.3 appears to be still partially available, but listing the directory contents doesn't show it.

saiarcot895 · 2023-01-06T17:53:06Z

I see #13276 is also fixing the same thing.

guillaumelambert · 2023-01-06T19:06:18Z

Technically, this is a package update, not just a version numbering fix. It's odd, though, that the dsc file for 4.4.1-2.3 appears to be still partially available, but listing the directory contents doesn't show it.

Yep I was referring to the variable name in the commit title indeed.
Maybe it would be worth to update this variable name too.
About the weird listing, this is a classical caching issue probably related to debian packages staging process..
I had access to the old dsc file from a different Internet access location where it was not yet removed.
Here are diff and grep results.
As you can see sources checksum are identical but not the debian packages ones.
I suspect this is only a renaming issue indeed.

hope this helps

diff isc-dhcp*.dsc
8c8
< Version: 4.4.1-2.3+deb11u1

Version: 4.4.1-2.3
27c27
< dcf53786e6b1650184fde075bbe25a0f3dd7e49c 89040 isc-dhcp_4.4.1-2.3+deb11u1.debian.tar.xz

aad326e51276efeb3d6d64b23f274eaaa329a737 88136 isc-dhcp_4.4.1-2.3.debian.tar.xz
30c30
< b693380b77195e6e742848be2a86248506b0c9bbbb461622daa1ad5b36d9ac54 89040 isc-dhcp_4.4.1-2.3+deb11u1.debian.tar.xz

8396ddc072a5f1d1863f95ba8f95cb4d6f0de3928615038eeaa8897d966dcd35 88136 isc-dhcp_4.4.1-2.3.debian.tar.xz
33c33
< 8c3640097a1b4cc59e927badbd45b3f0 89040 isc-dhcp_4.4.1-2.3+deb11u1.debian.tar.xz

72af4f677ebb88970bdcae0f73f2d9e8 88136 isc-dhcp_4.4.1-2.3.debian.tar.xz
37c37
< iQKmBAEBCgCQFiEERkRAmAjBceBVMd3uBUy48xNDz0QFAmM8nvlfFIAAAAAALgAo

iQKmBAEBCgCQFiEERkRAmAjBceBVMd3uBUy48xNDz0QFAmCvLJJfFIAAAAAALgAo
[...]>
grep -A3 Checksum isc-dhcp*.dsc
isc-dhcp_4.4.1-2.3+deb11u1.dsc:Checksums-Sha1:
isc-dhcp_4.4.1-2.3+deb11u1.dsc- 2c52eac4eb3dc9a2ecde623b1a687fa0146a6ce9 1189920 isc-dhcp_4.4.1.orig.tar.gz
isc-dhcp_4.4.1-2.3+deb11u1.dsc- dcf53786e6b1650184fde075bbe25a0f3dd7e49c 89040 isc-dhcp_4.4.1-2.3+deb11u1.debian.tar.xz
isc-dhcp_4.4.1-2.3+deb11u1.dsc:Checksums-Sha256:
isc-dhcp_4.4.1-2.3+deb11u1.dsc- c8e079dd4303ed121811b05c9f62a37669b2c8d91658d47a5ec58ec34e5a8247 1189920 isc-dhcp_4.4.1.orig.tar.gz
isc-dhcp_4.4.1-2.3+deb11u1.dsc- b693380b77195e6e742848be2a86248506b0c9bbbb461622daa1ad5b36d9ac54 89040 isc-dhcp_4.4.1-2.3+deb11u1.debian.tar.xz
isc-dhcp_4.4.1-2.3+deb11u1.dsc-Files:
--
isc-dhcp_4.4.1-2.3.dsc:Checksums-Sha1:
isc-dhcp_4.4.1-2.3.dsc- 2c52eac4eb3dc9a2ecde623b1a687fa0146a6ce9 1189920 isc-dhcp_4.4.1.orig.tar.gz
isc-dhcp_4.4.1-2.3.dsc- aad326e51276efeb3d6d64b23f274eaaa329a737 88136 isc-dhcp_4.4.1-2.3.debian.tar.xz
isc-dhcp_4.4.1-2.3.dsc:Checksums-Sha256:
isc-dhcp_4.4.1-2.3.dsc- c8e079dd4303ed121811b05c9f62a37669b2c8d91658d47a5ec58ec34e5a8247 1189920 isc-dhcp_4.4.1.orig.tar.gz
isc-dhcp_4.4.1-2.3.dsc- 8396ddc072a5f1d1863f95ba8f95cb4d6f0de3928615038eeaa8897d966dcd35 88136 isc-dhcp_4.4.1-2.3.debian.tar.xz
isc-dhcp_4.4.1-2.3.dsc-Files:
`

saiarcot895 · 2023-01-06T19:10:00Z

That's standard practice for the source package (orig.tar.*) being the same, but the debian package (debian.tar.*) being different, since the upstream version is the same, but Debian is making specific changes. See here for details on the new version.

guillaumelambert · 2023-01-06T19:45:55Z

So this is CVE security updates by Debian security team.
Thanks for the pointer.

During the build process, a dsc file is retrieved from the URL: http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc Depending on the DNS resolution, the server reached may respond with a HTTP 404 error code, what stops the build process. In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/ no more lists this DSC file but one with a different format. The suffix "+deb11u1" is now appended to identify the debian version. - append this suffix to the make file rules of isc-dhcp Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>

mssonicbld · 2023-01-11T21:54:11Z

Cherry-pick PR to 202205: #13339

During the build process, a dsc file is retrieved from the URL: http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc Depending on the DNS resolution, the server reached may respond with a HTTP 404 error code, what stops the build process. In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/ no more lists this DSC file but one with a different format. The suffix "+deb11u1" is now appended to identify the debian version. - append this suffix to the make file rules of isc-dhcp Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>

mssonicbld · 2023-01-13T05:34:37Z

Cherry-pick PR to 202211: #13357

During the build process, a dsc file is retrieved from the URL: http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc Depending on the DNS resolution, the server reached may respond with a HTTP 404 error code, what stops the build process. In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/ no more lists this DSC file but one with a different format. The suffix "+deb11u1" is now appended to identify the debian version. - append this suffix to the make file rules of isc-dhcp Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>

During the build process, a dsc file is retrieved from the URL: http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc Depending on the DNS resolution, the server reached may respond with a HTTP 404 error code, what stops the build process. In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/ no more lists this DSC file but one with a different format. The suffix "+deb11u1" is now appended to identify the debian version. - append this suffix to the make file rules of isc-dhcp Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com> Co-authored-by: Guilt <guillaume.lambert@orange.com>

Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334

guillaumelambert requested review from lguohan, qiluo-msft and xumia as code owners January 6, 2023 07:30

guillaumelambert mentioned this pull request Jan 6, 2023

[Build] Failed to build isc dhcp #13281

Closed

saiarcot895 added Request for 202205 Branch Request for 202211 Branch labels Jan 6, 2023

saiarcot895 approved these changes Jan 6, 2023

View reviewed changes

lguohan linked an issue Jan 8, 2023 that may be closed by this pull request

[Build] Failed to build isc dhcp #13281

Closed

lguohan merged commit 19010a3 into sonic-net:master Jan 8, 2023

lguohan mentioned this pull request Jan 8, 2023

[isc-dhcp]: Align package version with debian ftp #13276

Closed

8 tasks

guillaumelambert mentioned this pull request Jan 8, 2023

[build] Refactor URLs used with dget #13302

Closed

yxieca added the Approved for 202205 Branch label Jan 11, 2023

mssonicbld added the Created PR to 202205 Branch label Jan 11, 2023

mssonicbld mentioned this pull request Jan 11, 2023

[action] [PR:13288] [build] Fix isc-dhcp full version in rules.mk #13339

Merged

mssonicbld added a commit that referenced this pull request Jan 12, 2023

[build] Fix isc-dhcp full version in rules.mk (#13288) (#13339)

5a30233

mssonicbld added Included in 202205 Branch and removed Approved for 202205 Branch Created PR to 202205 Branch labels Jan 12, 2023

StormLiangMS added the Approved for 202211 Branch label Jan 13, 2023

mssonicbld added the Created PR to 202211 Branch label Jan 13, 2023

mssonicbld mentioned this pull request Jan 13, 2023

[action] [PR:13288] [build] Fix isc-dhcp full version in rules.mk #13357

Merged

mssonicbld added a commit that referenced this pull request Jan 13, 2023

[build] Fix isc-dhcp full version in rules.mk (#13288) (#13357)

9dfce87

mssonicbld added Included in 202211 Branch and removed Approved for 202211 Branch Created PR to 202211 Branch labels Jan 13, 2023

This was referenced Jan 16, 2023

[build] Check versions availability in rules/*.mk at init and use apt-get source instead of dget or wget in Makefiles #13379

Closed

[build] Check versions availability in rules/*.mk at init and use apt-get source instead of dget or wget in Makefiles #13381

Open

yxieca mentioned this pull request Mar 21, 2023

[202012][build] Fix isc-dhcp full version in rules.mk (#13288) #14376

Merged

8 tasks

ec-michael-shih mentioned this pull request Dec 5, 2023

[AS4630-54PE] Apply community PR edge-core/sonic-buildimage#13

Merged

7 tasks

ec-michael-shih mentioned this pull request Dec 12, 2023

[AS4630-54NPE] Apply community PR edge-core/sonic-buildimage#17

Merged

ec-michael-shih mentioned this pull request Jan 3, 2024

[AS9736-64d] Apply community PR edge-core/sonic-buildimage#24

Merged

7 tasks

tigerfu000 mentioned this pull request May 23, 2024

[Sync PRs and Fix bugs] For platforms: AS4630-54TE, AS5835-54X, AS7326-56X, AS7726-32X, AS9716-32D, and AS9736-64D edge-core/sonic-buildimage#46

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[build] Fix isc-dhcp full version in rules.mk#13288

[build] Fix isc-dhcp full version in rules.mk#13288
lguohan merged 1 commit intosonic-net:masterfrom
Orange-OpenSource:isc_dhcp

guillaumelambert commented Jan 6, 2023 •

edited

Loading

Uh oh!

guillaumelambert commented Jan 6, 2023

Uh oh!

saiarcot895 commented Jan 6, 2023

Uh oh!

saiarcot895 commented Jan 6, 2023

Uh oh!

guillaumelambert commented Jan 6, 2023 •

edited

Loading

diff isc-dhcp*.dsc
8c8
< Version: 4.4.1-2.3+deb11u1

Uh oh!

saiarcot895 commented Jan 6, 2023

Uh oh!

guillaumelambert commented Jan 6, 2023

Uh oh!

mssonicbld commented Jan 11, 2023

Uh oh!

mssonicbld commented Jan 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

guillaumelambert commented Jan 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

guillaumelambert commented Jan 6, 2023

Uh oh!

saiarcot895 commented Jan 6, 2023

Uh oh!

saiarcot895 commented Jan 6, 2023

Uh oh!

guillaumelambert commented Jan 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

diff isc-dhcp*.dsc 8c8 < Version: 4.4.1-2.3+deb11u1

Uh oh!

saiarcot895 commented Jan 6, 2023

Uh oh!

guillaumelambert commented Jan 6, 2023

Uh oh!

mssonicbld commented Jan 11, 2023

Uh oh!

mssonicbld commented Jan 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

guillaumelambert commented Jan 6, 2023 •

edited

Loading

guillaumelambert commented Jan 6, 2023 •

edited

Loading

diff isc-dhcp*.dsc
8c8
< Version: 4.4.1-2.3+deb11u1