Skip to content

[docker-teamd]: Manage teamd and teamsyncd processes with supervisor#1137

Merged
jleveque merged 4 commits intosonic-net:masterfrom
jleveque:supervise_teamd
Nov 13, 2017
Merged

[docker-teamd]: Manage teamd and teamsyncd processes with supervisor#1137
jleveque merged 4 commits intosonic-net:masterfrom
jleveque:supervise_teamd

Conversation

@jleveque
Copy link
Copy Markdown
Contributor

- What I did

  • Ensure all teamd and teamsyncd processes inside docker-teamd are managed by supervisor to ensure we receive syslog messages if any of these processes exit unexpectedly.

- How I did it

  • Generate supervisor config file dynamically from a Jinja2 template using docker-teamd-init.sh to accommodate variances in LAG configuration.

- How to verify it

  • Start / stop teamd docker (via systemctl start/stop teamd) and ensure all processes start/stop properly, and that teamd processes clean up after themselves properly.
  • Kill teamd process(es) via signals and ensure supervisor writes appropriate syslog messages.

- A picture of a cute animal (not mandatory but encouraged)

¸.·´¯`·.´¯`·.¸¸.·´¯`·.¸><(((º>

@jleveque jleveque self-assigned this Nov 10, 2017
@jleveque jleveque requested review from lguohan and stcheng November 10, 2017 00:37
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also provide a sample output here?

@stcheng
Copy link
Copy Markdown
Contributor

stcheng commented Nov 10, 2017

can you also add corresponding j2 tests?

Copy link
Copy Markdown
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to add config gen unit test for the templates you have used.

@jleveque jleveque merged commit a6edef2 into sonic-net:master Nov 13, 2017
@jleveque jleveque deleted the supervise_teamd branch November 13, 2017 22:16
stcheng pushed a commit that referenced this pull request Nov 16, 2017
…ervisor (#1137)" (#1156)

This reverts commit a6edef2.

The reason to revert this commit is that it breaks the current nightly test as
no port channel interfaces are get created after boot. teamd failed to start and
complained about 'Cannot allocate memory' possibly due to nlmsg_alloc function
failure.

Will revert this commit to investigate it further before moving to supervisor.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
abdosi added a commit that referenced this pull request Sep 29, 2020
[cli][bgp]use vtysh in the show ip bgp summary command (#1137)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
lguohan pushed a commit that referenced this pull request Oct 6, 2020
- [acl-loader] Revert fix for IP protocol == 0 (#1142)
- Show sflow interface to display all interfaces enabled for sflow (#1143)
- [sflow_test.py]: tests for config sflow commands. (#1112)
- [config/console] Support add/del console port setting commands (#1136)
- [cli][bgp]use vtysh in the show ip bgp summary command (#1137)
- [README.md] Describe new package creation schema (#1131)
- [consutil] Remove actual baud and refactor lib for future change (#1130)

Signed-off-by: Danny Allen <daall@microsoft.com>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
…t#5545)

- [acl-loader] Revert fix for IP protocol == 0 (sonic-net#1142)
- Show sflow interface to display all interfaces enabled for sflow (sonic-net#1143)
- [sflow_test.py]: tests for config sflow commands. (sonic-net#1112)
- [config/console] Support add/del console port setting commands (sonic-net#1136)
- [cli][bgp]use vtysh in the show ip bgp summary command (sonic-net#1137)
- [README.md] Describe new package creation schema (sonic-net#1131)
- [consutil] Remove actual baud and refactor lib for future change (sonic-net#1130)

Signed-off-by: Danny Allen <daall@microsoft.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

Modify the run_bgp_command function to call vtysh with correct instance_id and vtysh cmd.
The vtysh script is modified to take the namespace id in this PR sonic-net#5479
skr31 pushed a commit to skr31/sonic-buildimage that referenced this pull request May 25, 2025
<!--
Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

** Make sure all your commits include a signature generated with `git
commit -s` **

If this is a bug fix, make sure your description includes "fixes #xxxx",
or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it

#### How to verify it

<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants