Skip to content

Restart ntp after ntp-config#1106

Merged
taoyl-ms merged 2 commits intosonic-net:masterfrom
taoyl-ms:taoyl/ntp
Nov 7, 2017
Merged

Restart ntp after ntp-config#1106
taoyl-ms merged 2 commits intosonic-net:masterfrom
taoyl-ms:taoyl/ntp

Conversation

@taoyl-ms
Copy link
Copy Markdown
Contributor

@taoyl-ms taoyl-ms commented Nov 3, 2017

- What I did
In ntp-config service, explicitly restart ntp service after generating ntp.conf file

@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented Nov 4, 2017

Does removing the ntp.service dependency fix the issue that caused Shuotian to revert this change a few days ago (#1102)?

@stcheng
Copy link
Copy Markdown
Contributor

stcheng commented Nov 7, 2017

how you verify with this change?

@taoyl-ms
Copy link
Copy Markdown
Contributor Author

taoyl-ms commented Nov 7, 2017

Yes, this fix #1102.

@taoyl-ms
Copy link
Copy Markdown
Contributor Author

taoyl-ms commented Nov 7, 2017

I manually set wrong hwclock on a test device, didn't specify ntp server in minigraph, and re-imaged the box. When it's loaded, the system clock was wrong because ntp was not working. I then manually wrote correct ntp server into configdb, ran service restart ntp-config, and observed the system clock was corrected by ntp.

@taoyl-ms taoyl-ms merged commit f7c3972 into sonic-net:master Nov 7, 2017
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
sonic-net#1106)

* [aclorch] if vendor does not implement ACL action capability quieries - use default capabilities (do not fail)
abdosi added a commit that referenced this pull request Sep 19, 2020
Revert "Revert " [201911]show interface counters for multi ASIC devices
(#1104)""
 Revert "Revert "Pfcstat (#1097)""
  [show] Fix 'show int neighbor expected' (#1106)
   Update argument for docker exec it->i (#1118)
     Update to make config load/reload backward compatible. (#1115)
     Handling deletion of Port Channel before deletion of its members
     (#1062)
    Skip default route present in ASIC-DB but not in APP-DB. (#1107)
     [CLI][PFCWD][Multi-ASIC] Added multi ASIC support to 'pfcwd' CLI
     (#1102)
       [201911]  Multi asic platform config interface portchannel, show
       transceiver  (#1087)
       [drop counters] Fix configuration for counters with lowercase
       names (#1103)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request May 12, 2025
…HEAD automatically (sonic-net#1106)

#### Why I did it
src/sonic-swss-common
```
* 3138395 - (HEAD -> 202412, origin/HEAD, origin/202412) [trim]: Add Packet Trimming DB schema (#44) (18 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants