Add CMIS_and_C-CMIS_support_for_ZR.md#769
Add CMIS_and_C-CMIS_support_for_ZR.md#769qinchuanares wants to merge 465 commits intosonic-net:masterfrom
Conversation
|
|
|
@qinchuanares: CMIS spec supports firmware updates, which we will want to support in SONiC. I don't see that covered here. Is this something you have considered? |
|
@jleveque Good points. I have not covered the FW upgrade part yet. I will work on this feature in the following week and add it in the document. |
|
A general comment: in the HLD for SONiC integration we need to see flows.my suggestion is to extend the https://github.com/Azure/SONiC/blob/master/doc/xrcvd/transceiver-monitor-hld.md with the SONiC flows and the additional functionality required. this current md file can be used as a reference to understand what it means and with the code sample examples. but it is too detailed for understanding the damon behaviour, DBs relations and what are the CLIs that you are expected to add including which DBs are affected and what is the schema. especially if you are referring to new parameters that need to be used in order to configure and control it. |
prgeor
left a comment
There was a problem hiding this comment.
@qinchuanares could address comments?
There was a problem hiding this comment.
Can we have separate state table for Module and Datapath as CMIS spec distinguishes states of module and datapath?
There was a problem hiding this comment.
Will the CLI restrict the firmware type to "binary" only? or "ASCII" format is also supported?
There was a problem hiding this comment.
CLI does not restrict the firmware file type. But my code opens the file in "rb" mode.
There was a problem hiding this comment.
Can you state in the CLI help what does "commit" firmware do?
There was a problem hiding this comment.
When is user supposed to use this CLI?
There was a problem hiding this comment.
This CLI is already present in SONiC. Let's not change the output of this existing CLI. To show module statue add new CLI:-
show interfaces transceiver module-status Ethernet0
add section number and update CLI for module firmware upgrade
…m; re-organize the HLD structure to align with the diagram description
Clean up the diagram flowchart
Update configure CLI command: configured_frequency -> frequency configured_tx_power -> tx_power
Added items: 1. vendor revision (Page 0, Offset 164-165) 2. inactive firmware (Page 1, Offset 128-129) Removed items: 1. type (same item as ext_identifier) 2. ext_rateselect_compliance (not applicable) 3. encoding (not applicable) 4. cable_type (same item as module_media_type) 5. cable_length (not applicable for ZR) 6. nominal_bit_rate (not applicable for ZR)
1. Separate loopback status as new table in state_db 2. add supported laser frequency and supported tx power into state_db
5eddd56 to
df79f84
Compare
df79f84 to
1a62784
Compare
|
/easycla |
|
"/easycla" |
|
Close this PR and use #1076 to track. |
The markdown file "CMIS_and_C-CMIS_support_for_ZR.md" describes the work to provide CMIS and C-CMIS support on 400G ZR, a new generation of coherent optical modules to run on SONiC platforms. The markdown article focuses on how to access the registers with the definitions given in CMIS and C-CMIS documents and to achieve certain high-level tasks/functions at the module level. It breaks the process down to four architectural layers and shows each layer at a high level.