Firmware upgrade CLI support for QSFP-DD transceivers#244
Merged
prgeor merged 2 commits intosonic-net:masterfrom Nov 29, 2021
Merged
Firmware upgrade CLI support for QSFP-DD transceivers#244prgeor merged 2 commits intosonic-net:masterfrom
prgeor merged 2 commits intosonic-net:masterfrom
Conversation
Contributor
qinchuanares
left a comment
There was a problem hiding this comment.
Why remove test_get_module_fw_mgmt_feature()?
Collaborator
Author
all hw reads are mocked and its just some string comparisons. it needs lot of effort to understand the parametrized mock input arguments which is quite long! |
andywongarista
suggested changes
Nov 26, 2021
lguohan
previously approved these changes
Nov 26, 2021
Signed-off-by: Prince George <prgeor@microsoft.com>
lguohan
approved these changes
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes to support firmware upgrade CLI for QSFP-DD transceivers
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)