HLD for ICMP Hardware Offload#1952
Merged
qiluo-msft merged 7 commits intosonic-net:masterfrom Jan 5, 2026
Merged
Conversation
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
zjswhhh
reviewed
Mar 28, 2025
zjswhhh
reviewed
Apr 2, 2025
Contributor
zjswhhh
left a comment
There was a problem hiding this comment.
Missing TLV packets handling.
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
Author
Added a section on TLV generation. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
Closed by mistake |
zjswhhh
reviewed
Apr 6, 2025
Contributor
There was a problem hiding this comment.
LinkMgrd -> Mux State Standby -> APPL_DB
fca6e10 to
8226d51
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
8226d51 to
c8147a6
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
c8147a6 to
5815c65
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
5815c65 to
b18cfc3
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
b18cfc3 to
711da6c
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
711da6c to
f2c299d
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
d68000a to
398b0a3
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
9bcea68 to
62aa374
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
zjswhhh
previously approved these changes
Sep 23, 2025
Contributor
|
Hi @zhangyanzhao - this HLD has been reviewed in community, comments are addressed. Can you help merge please? |
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
zjswhhh
approved these changes
Sep 24, 2025
Contributor
Author
|
@lolyu can you take a look at the latest version and provide your comments? |
Contributor
|
Hi @qiluo-msft - please help merge. Thanks. |
justin-wong-ce
pushed a commit
to justin-wong-ce/SONiC
that referenced
this pull request
Jan 28, 2026
This is HLD for ICMP Hardware Offload. It is used in DualTor architecture for Protection switching. Related PRs and spec SAI spec: icmpecho offload sonic-swss-common sonic-sairedis: icmpecho support sonic-swss: IcmpOrch sonic-linkmgrd sonic-utilities: icmp sonic-utilities: mux sonic-buildimage: yang sonic-mgmt: prober-type Signed-off-by: Justin Wong <jvwong@arista.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is HLD for ICMP Hardware Offload. It is used in DualTor architecture for Protection switching.
Related PRs and spec
SAI spec: icmpecho offload
sonic-swss-common
sonic-sairedis: icmpecho support
sonic-swss: IcmpOrch
sonic-linkmgrd
sonic-utilities: icmp
sonic-utilities: mux
sonic-buildimage: yang
sonic-mgmt: prober-type