Skip to content

Conversation

@Mitzi-Laszlo
Copy link

Solution associated to conversation on solid-contrib/information#48

@Mitzi-Laszlo Mitzi-Laszlo requested a review from timbl July 24, 2019 15:46
@Mitzi-Laszlo Mitzi-Laszlo added the process proposal Process proposal to be reviewed by Solid Director label Jul 24, 2019
@justinwb
Copy link
Member

@Mitzi-Laszlo Went through and applied updates as requested. You can see the differences in this commit. A few details on the rationale behind some of the changes:

  • Panels: Added a rule that repos created for panels have to be suffixed with "-panel". The reason for this is that it would otherwise be confusing for someone coming to the solid github organization, looking for definitive guidance on a topic, and mistaking a panel repository for that definitive guidance. These repos will have tons of content that hasn't gone through editorial review and acceptance. Since anyone can create a panel, and panels can request to have a repo made, i believe this rule is important to impose.
  • Editors: Editors need the ability to do more than triage. I touched on this here, but to add another reason - merging isn't always just a button click. Often there are cases where conflicts need to be resolved, and unless someone is well-informed on the substance of the material (editor or author), they're aren't in a position to resolve conflicts correctly. IMO - this isn't the place of an administrator, it's part of editorial responsibility.
  • There was a section in "Becoming an Administrator" that didn't have anything to do with becoming an administrator. It essentially said if you don't have a role that's already been named, you have regular public access. It seemed superfluous so I removed it.

Copy link
Contributor

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree in general, just think there is a confusion wrt Editor.


The Solid Manager, who is also an editor, is appointed by the Solid Director. The Solid Manager is responsible for formalizing the outcome of any votes.

Editors belong to the [Editors team](https://github.com/orgs/solid/teams/editors) in the [Solid GitHub Organization](https://github.com/solid) and have [_Maintain Permissions_](https://help.github.com/en/articles/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization) on all repositories therein.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Editor role is being misunderstood (in general, not just in this PR).

To me (and to a typical W3C group), an editor is always in relation to a document. So you are an editor of document X or Y; you're not an editor in absolute terms.

The role of "editor" seems to have gotten some special meaning that IMHO is not needed or desired. Editors just need write access to the solid/specification repository, and the authority to approve/merge pull requests to a specific document.

@justinwb
Copy link
Member

justinwb commented Aug 3, 2019

This pull request has been succeeded by #95. This branch and its associated version history was merged into that branch and then modified further. Closing this pull request.

@justinwb justinwb closed this Aug 3, 2019
@justinwb justinwb deleted the GitHub-Permissions branch August 3, 2019 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

process proposal Process proposal to be reviewed by Solid Director

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants