Properly delete Scarb managed cache in tests#2863
Merged
Conversation
ed19b19 to
a0e0ddb
Compare
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
15b27c1 to
fab3a9f
Compare
Contributor
Author
fab3a9f to
fbae369
Compare
DelevoXDG
reviewed
Nov 21, 2025
9c5aa24 to
990dcb1
Compare
990dcb1 to
b507616
Compare
DelevoXDG
approved these changes
Nov 24, 2025
maciektr
added a commit
that referenced
this pull request
Nov 25, 2025
Temp directory created by `TempDir` is removed from disk when the associated `TempDir` is dropped. When running Scarb in tests, new TempDir for Scarb cache is created and passed via env to the Scarb process. However, if the TempDir is dropped before calling Scarb, Scarb will re-create the cache directory on run, never actually deleting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temp directory created by
TempDiris removed from disk when the associatedTempDiris dropped.When running Scarb in tests, new TempDir for Scarb cache is created and passed via env to the Scarb process.
However, if the TempDir is dropped before calling Scarb, Scarb will re-create the cache directory on run, never actually deleting it.