Conversation
piotmag769
reviewed
Nov 12, 2025
bc903b3 to
adf31b0
Compare
Contributor
Author
|
snfoundry PR foundry-rs/starknet-foundry#3932 |
adf31b0 to
cfd7025
Compare
cfd7025 to
dd86358
Compare
FroyaTheHen
approved these changes
Nov 25, 2025
DelevoXDG
reviewed
Nov 25, 2025
| fsx::create_dir_all(path.parent().expect("file path must have a parent"))?; | ||
|
|
||
| match content_path { | ||
| SourcePath::SkipDuplicated(path) if path.exists() => continue, |
Contributor
There was a problem hiding this comment.
Shouldn't we check existence of canonical_path.join(path)? It seems we're checking the existence of the relative path here 🤔
maciektr
added a commit
that referenced
this pull request
Nov 25, 2025
maciektr
added a commit
that referenced
this pull request
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.