Fix gestureHandlerRootHOC types#1347
Merged
jgonet merged 4 commits intosoftware-mansion:masterfrom Feb 12, 2021
Merged
Conversation
jgonet
reviewed
Feb 10, 2021
Member
jgonet
left a comment
There was a problem hiding this comment.
Looks good, could you restrict P a little bit by writing P extends object?
Member
|
Also, could you provide some small piece of code that can be used to test this change? |
Contributor
Author
|
Sample code: import React from 'react';
import {Text, View} from 'react-native';
import {gestureHandlerRootHOC} from 'react-native-gesture-handler';
import {Navigation} from 'react-native-navigation';
function MyScreen(props: {componentId: string}) {
return (
<View>
<Text>{props.componentId}</Text>
</View>
);
}
Navigation.registerComponent('my-screen', () =>
gestureHandlerRootHOC(MyScreen),
); |
Member
Looks like the TS compiler doesn't like this, I changed |
Contributor
Author
|
It sort of works. If I factor out the props definition as a type, it works fine. type MyProps = {
componentId: string;
};
function MyScreen(props: MyProps) {
return (
<View>
<Text>{props.componentId}</Text>
</View>
);
}But fails if I use an interface. (Important if, for example, using interface MyProps {
componentId: string;
}
function MyScreen(props: MyProps) {
return (
<View>
<Text>{props.componentId}</Text>
</View>
);
} |
Member
|
All right, I will change it to P in the followup. Thanks for checking this. |
braincore
pushed a commit
to braincore/react-native-gesture-handler
that referenced
this pull request
Mar 4, 2021
Co-authored-by: Jakub <jakub.gonet@swmansion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the most recent update,
gestureHandlerRootHOC()gives errors like:Test plan
yarn ts-checkThe only change is typings which now allow my project to run clean.