Skip to content

Improve wording in LongPressGH's docs#1320

Merged
jgonet merged 3 commits intosoftware-mansion:masterfrom
jtalz:adjustLongPressHandler
Feb 2, 2021
Merged

Improve wording in LongPressGH's docs#1320
jgonet merged 3 commits intosoftware-mansion:masterfrom
jtalz:adjustLongPressHandler

Conversation

@jtalz
Copy link
Copy Markdown
Contributor

@jtalz jtalz commented Jan 25, 2021

made some english fixes and changed "default value" to agree with react native docs

@jtalz
Copy link
Copy Markdown
Contributor Author

jtalz commented Jan 27, 2021

Please review that the default values are indeed accurate

@jgonet jgonet changed the title Adjust longpressgesture docs Improve wording in LongPressGH's docs Feb 2, 2021
Copy link
Copy Markdown
Member

@jgonet jgonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some suggestions.

jtalz and others added 2 commits February 2, 2021 07:44
this -> `absoluteX`

Co-authored-by: Jakub <jakub.gonet@swmansion.com>
Co-authored-by: Jakub <jakub.gonet@swmansion.com>
Copy link
Copy Markdown
Member

@jgonet jgonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jgonet jgonet merged commit 307c3ad into software-mansion:master Feb 2, 2021
mrousavy pushed a commit to mrousavy/react-native-gesture-handler that referenced this pull request Feb 11, 2021
Co-authored-by: Jakub <jakub.gonet@swmansion.com>
braincore pushed a commit to braincore/react-native-gesture-handler that referenced this pull request Mar 4, 2021
Co-authored-by: Jakub <jakub.gonet@swmansion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants