Fix RNGestureHandlerManager to use explicit imports#1160
Merged
jkadamczyk merged 3 commits intosoftware-mansion:masterfrom Sep 1, 2020
Merged
Conversation
added 3 commits
August 7, 2020 15:50
…com/PeteTheHeat/react-native-gesture-handler into fix_RNGestureHandlerManager_imports
jgonet
approved these changes
Aug 24, 2020
Member
jgonet
left a comment
There was a problem hiding this comment.
It's interesting that the RN uses RNGH internally, is it open-sourced?
Contributor
Author
|
Sorry, I should have been more clear. Facebook uses RNGH internally in a few apps. In order to land my refactor to RN core, those apps must build. |
jkadamczyk
approved these changes
Sep 1, 2020
Contributor
|
I think we can merge that. Builds are passing on CI. |
Contributor
|
Thanks for your contribution @PeteTheHeat |
braincore
pushed a commit
to braincore/react-native-gesture-handler
that referenced
this pull request
Mar 4, 2021
…#1160) * change imports * change imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I work on RN Core at Facebook, and am encountering a unique problem. I'm trying to refactor
RCTEventDispatcher, but cannot because of the implicit dependency onRCTEventDispatcherinRNGestureHandlerManager. We use rn-gesture-handler internally, and builds for it fail after the refactor.The fix is to explicitly depend on
RCTEventDispatcherinstead of relying on theRCTUIManager -> RCTViewManager -> RCTEventDispatcherimport chain.Test plan
I unfortunately did not test this. I can't get react-native-gesture-handler building locally. I assume that there are CI builds that would fail on a simple compilation error.