Skip to content

fix: display Snyk Code disabled in the tree view [IDE 1538]#339

Merged
nick-y-snyk merged 2 commits intofeat/IDE-1368_consume_org_from_serverfrom
IDE-1538
Nov 18, 2025
Merged

fix: display Snyk Code disabled in the tree view [IDE 1538]#339
nick-y-snyk merged 2 commits intofeat/IDE-1368_consume_org_from_serverfrom
IDE-1538

Conversation

@nick-y-snyk
Copy link
Copy Markdown
Contributor

@nick-y-snyk nick-y-snyk commented Nov 14, 2025

Description

image

Removed json handling logic, because errorMessage is always a simple string, there is a cliError field on ScanParams, but it's not present in Eclipse. So looks like error handling has been broken for a while

Checklist

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@nick-y-snyk nick-y-snyk requested review from a team as code owners November 14, 2025 08:50
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 14, 2025

CLA assistant check
All committers have signed the CLA.

@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Nov 14, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@nick-y-snyk nick-y-snyk changed the base branch from main to feat/IDE-1368_consume_org_from_server November 14, 2025 08:51
@acke acke force-pushed the feat/IDE-1368_consume_org_from_server branch from e097d77 to 36a0a92 Compare November 14, 2025 11:54
String errorJson = ptn.getErrorMessage();
if (errorJson != null && !errorJson.isBlank()) {
String error = ptn.getErrorMessage();
if (error != null && !error.isBlank()) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle json CliError too

@nick-y-snyk nick-y-snyk changed the title Ide 1538 fix: display Snyk Code disabled in the tree view [IDE 1538] Nov 18, 2025
@nick-y-snyk nick-y-snyk merged commit 70a7529 into feat/IDE-1368_consume_org_from_server Nov 18, 2025
6 checks passed
@nick-y-snyk nick-y-snyk deleted the IDE-1538 branch November 18, 2025 10:07
nick-y-snyk added a commit that referenced this pull request Nov 19, 2025
nick-y-snyk added a commit that referenced this pull request Nov 19, 2025
andrewrobinsonhodges-snyk pushed a commit that referenced this pull request Nov 21, 2025
* feat: add organization to project properties

* fix: imports, pmd violations

* fix: bump jackson deps

* fix: bump core-text dep

* fix: bump lang3 dep

* fix: a few bugs with NPEs

* fix: add checkbox

* fix: add selection listeners to property page

* fix: handle auto org correctly

* fix: remove validation, so we can set an empty org in project settings and use global org

* fix: remove unneeded org logic

* fix: update the UI labels and make pref page behave even if ls has not started

* fix: added a context menu for open project preferences

* fix: clean up UI for auto org

Added help text to Snyk Code Security checkbox: "Snyk Code scans must be
enabled for the organization to run."
Removed disableSnykCodeIfOrgDisabled() method and all calls to it
Snyk Code checkbox is always selectable, regardless of SAST/org status
Removed conditional logic in toggleIgnoresButtons() that hid filters
based on CCI status
Open Issues and Ignored Issues filters are always visible
Updated tooltips in plugin.xml to mention: "Note: This filter will only
take effect if Code Consistent Ignores (CCI) is enabled for the
organization."

* fix: remove LCE from sast settings

* fix: remove (CCI) from tooltips

* fix: fix linter on generic exception

* fix: remove tooltip from checkbox

* fix: add back the org enabled for code

* fix: fixed duplicate of code must be enabled label.

* fix: disable auto org by default

* fix: display Snyk Code disabled in the tree view [IDE 1538] (#339)

fix: error html view

---------

Co-authored-by: Knut Funkel <knut.funkel@snyk.io>
Co-authored-by: nick-y-snyk <nikita.yasnohorodskyi@snyk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants