Skip to content

Escaping CDATA closing tag in CDATA#69

Merged
snoyberg merged 3 commits intosnoyberg:masterfrom
vigoo:cdata-escape
Dec 21, 2015
Merged

Escaping CDATA closing tag in CDATA#69
snoyberg merged 3 commits intosnoyberg:masterfrom
vigoo:cdata-escape

Conversation

@vigoo
Copy link
Copy Markdown
Contributor

@vigoo vigoo commented Dec 16, 2015

Handles CDATA closing tag (]]>) while rendering CDATA in the same way as the Text.XML.Light package does.

@vigoo
Copy link
Copy Markdown
Contributor Author

vigoo commented Dec 16, 2015

Note: depends on #68 because of it's unit test case.

@snoyberg
Copy link
Copy Markdown
Owner

This looks like a terribly inefficient implementation. Wouldn't a simple call to Data.Text.replace be simpler and more efficient?

@vigoo
Copy link
Copy Markdown
Contributor Author

vigoo commented Dec 21, 2015

Yes you are right, I guess I was tired :)

snoyberg added a commit that referenced this pull request Dec 21, 2015
Escaping CDATA closing tag in CDATA
@snoyberg snoyberg merged commit c95bcd0 into snoyberg:master Dec 21, 2015
@snoyberg
Copy link
Copy Markdown
Owner

Cool, merged

snoyberg added a commit that referenced this pull request Dec 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants