Skip to content

Add functions to ignore subtrees & result-streaming (yield) parsers - cont.#58

Merged
snoyberg merged 20 commits intosnoyberg:masterfrom
pavelkogan:ignoretree
Jul 17, 2015
Merged

Add functions to ignore subtrees & result-streaming (yield) parsers - cont.#58
snoyberg merged 20 commits intosnoyberg:masterfrom
pavelkogan:ignoretree

Conversation

@pavelkogan
Copy link
Copy Markdown
Contributor

Continuation of #40

@creichert
Copy link
Copy Markdown

Nice, this is a feature I've wanted for a while.

Some of the naming was a little confusing to me at first (tagIngore* and ignoreTag* variants) but overall the changes look pretty good. I don't see any immediate issues in the implementation. +1

@snoyberg
Copy link
Copy Markdown
Owner

LGTM. @ulikoehler mind giving a thumbs up before I merge?

@ulikoehler
Copy link
Copy Markdown
Contributor

Definitively a thumbs up from me ;-)

Thank you very much @pavelkogan for finally finishing this feature. I'm very glad to see this included in xml-conduit.

@creichert I fully agree. I started to work on this about a year ago but I never got around to finishing it du to too heavy workload from university and job.

I'll close the old PR.

snoyberg added a commit that referenced this pull request Jul 17, 2015
Add functions to ignore subtrees & result-streaming (yield) parsers - cont.
@snoyberg snoyberg merged commit b2c55d7 into snoyberg:master Jul 17, 2015
@snoyberg
Copy link
Copy Markdown
Owner

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants