Reuse 'MonadThrow' and 'force' for 'AttrParser'#52
Merged
snoyberg merged 1 commit intosnoyberg:masterfrom May 9, 2015
Merged
Conversation
snoyberg
added a commit
that referenced
this pull request
May 9, 2015
Reuse 'MonadThrow' and 'force' for 'AttrParser'
Owner
|
Thanks! You're definitely taking a lot of interest in this library, and contributing good stuff. Would you be interested in becoming a comaintainer of it? |
Collaborator
Author
|
I would be glad to help maintaining |
Owner
|
I mostly just don't want to become a roadblock to you making improvements to this library :) If you tell me your Hackage username, I'll add you to the maintainer group. |
Collaborator
Author
|
My Hackage username is koral. Thank you :) |
Owner
|
Cool, done. On Mon, May 11, 2015 at 1:36 PM k0ral notifications@github.com wrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
MonadThrowinstance forAttrParsermakes it possible to:optionalAttr/requireAttrwithattr/force, which is simpler and consistent with the rest of the API.I made sure changes are backward-compatible.