Added helper functions to render XML elements#48
Merged
snoyberg merged 1 commit intosnoyberg:masterfrom May 5, 2015
Merged
Conversation
Owner
|
I very rarely have a need anymore to generate XML in a streaming manner, so I don't have many thoughts on this. The PR looks good enough to me as-is. I don't have any feedback for you right now; would you make whatever changes you'd like and ping me when it's ready, and I'll merge it in? |
Collaborator
Author
|
I've spent some time testing the new functions, they are working fine so I won't push further changes, you can merge it. |
snoyberg
added a commit
that referenced
this pull request
May 5, 2015
Added helper functions to render XML elements
Owner
|
Merged and released to Hackage and 1.2.5, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text.XML.Stream.Parseprovides helpers liketag,contentandrequireAttr, to avoid dealing with bareEvents.On the other side,
Text.XML.Stream.Renderprovides no such tools. This PR tries to fill the gap (also, stylish-haskell went by :) ).I'm not expecting it to be merged as is, this is somewhat a draft version, please let me know of the adjustments you would require before merging. Some points worth discussing:
tag,optionalAttrandcontentwill conflict with their parsing homonyms, do we really want that ?Attributeswrapper ?optionalAttr?