Configurable time bound#92
Merged
snoyberg merged 4 commits intosnoyberg:masterfrom May 3, 2015
geraldus:configurable-time-bound
Merged
Configurable time bound#92snoyberg merged 4 commits intosnoyberg:masterfrom geraldus:configurable-time-bound
snoyberg merged 4 commits intosnoyberg:masterfrom
geraldus:configurable-time-bound
Conversation
Keter/Proxy.hs
Outdated
Owner
There was a problem hiding this comment.
I'd still like a reference to that issue around the timeBound code, as it's likely to confuse someone in the future.
Contributor
Author
There was a problem hiding this comment.
Well, I'll restore this right now (:
Owner
|
I just had one comment regarding leaving in a reference to issue #29. Otherwise, this looks great! |
Implemented connection time bound option for both V04 and V10 configurations, default value is set to 5000ms.
Extend `reverseProxy` and `withClient` function with additional time bound parameter. Pass time bound from app configuration when running reverse proxies.
Contributor
Author
|
Ready! |
Owner
|
Thanks! Releasing to Hackage now. |
Contributor
There was a problem hiding this comment.
This is 5s not 5 minutes... shhould be:
5 * 60 * 1000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@snoyberg , ok, it seems I've done. Please review, I can remove last two commits. Also I didn't bumped version, because I'm not sure is it breaking change or not.