Add a default 0 value for start and end in the media_element entity time ranges #1428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
matus-tomlein
added a commit
that referenced
this pull request
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to prevent a schema validation error occurs for some mobile browsers which seem to be omitting the
endvalue in timeranges within theseekableproperty in themedia_elemententity schema.I couldn't reproduce this unfortunately but assume it is some type of browser bug, so the best I can think of doing is to add a default 0 value to the
startandendproperties within the time ranges.If you have some better ideas, please let me know!
The majority of failed events for the customer have the following value for the seekable property: