Skip to content

SNOW-439518 removing cloud sdks#845

Merged
sfc-gh-mkeller merged 4 commits intomasterfrom
mkeller-SNOW-439518-remove_sdks
Oct 7, 2021
Merged

SNOW-439518 removing cloud sdks#845
sfc-gh-mkeller merged 4 commits intomasterfrom
mkeller-SNOW-439518-remove_sdks

Conversation

@sfc-gh-mkeller
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller commented Aug 27, 2021

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-439518

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Following up SNOW-300951 removing cloud SDKs #725 and actually removing the SDKs as dependencies.

@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller-SNOW-439518-remove_sdks branch from 1909089 to 17b0f4c Compare August 27, 2021 01:56
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021 •
edited
Loading

Codecov Report

Merging #845 (e5b3a7c) into master (69a32d4) will increase coverage by 1.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
+ Coverage   82.58%   84.38%   +1.79%     
==========================================
  Files          64       58       -6     
  Lines        9033     7728    -1305     
  Branches     1378     1129     -249     
==========================================
- Hits         7460     6521     -939     
+ Misses       1184      903     -281     
+ Partials      389      304      -85
Impacted Files Coverage Δ
src/snowflake/connector/cursor.py 93.42% <100.00%> (-0.05%) ⬇️
src/snowflake/connector/errors.py 90.27% <0.00%> (-0.55%) ⬇️
src/snowflake/connector/file_transfer_agent.py 85.68% <0.00%> (-0.22%) ⬇️
src/snowflake/connector/connection.py 92.33% <0.00%> (-0.17%) ⬇️
src/snowflake/connector/network.py 81.60% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a32d4...e5b3a7c. Read the comment docs.

@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller-SNOW-439518-remove_sdks branch from 17b0f4c to e13839c Compare August 27, 2021 07:18
@sfc-gh-mkeller sfc-gh-mkeller changed the title SNOW-439518 removed non-sdkless tests SNOW-439518 removing cloud sdks Aug 27, 2021
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller-SNOW-439518-remove_sdks branch from e13839c to e5b3a7c Compare September 30, 2021 16:48
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller-SNOW-439518-remove_sdks branch from e5b3a7c to 7edbddd Compare October 5, 2021 21:40
@sfc-gh-mkeller sfc-gh-mkeller marked this pull request as ready for review October 6, 2021 21:57
@sfc-gh-mkeller sfc-gh-mkeller self-assigned this Oct 6, 2021
@sfc-gh-mkeller sfc-gh-mkeller linked an issue Oct 6, 2021 that may be closed by this pull request
SNOW-141545: Request - Reduce package dependencies chaos #284
Closed
sfc-gh-jbahk
sfc-gh-jbahk approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@sfc-gh-jbahk sfc-gh-jbahk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-mkeller sfc-gh-mkeller merged commit 21cd719 into master Oct 7, 2021
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller-SNOW-439518-remove_sdks branch October 7, 2021 17:08
This was referenced Oct 7, 2021
Closed
Merged
sfc-gh-aling pushed a commit that referenced this pull request Oct 17, 2022
@sfc-gh-mkeller
SNOW-439518 removing cloud sdks (#845)
e14a1aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sfc-gh-kwagner sfc-gh-kwagner sfc-gh-kwagner approved these changes

@sfc-gh-jbahk sfc-gh-jbahk sfc-gh-jbahk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sfc-gh-mkeller sfc-gh-mkeller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SNOW-141545: Request - Reduce package dependencies chaos

4 participants

@sfc-gh-mkeller @codecov-commenter @sfc-gh-kwagner @sfc-gh-jbahk