Skip to content

Add -p to mkdir#4069

Merged
johanneskoester merged 2 commits intosnakemake:mainfrom
clelange:rules_example_followup
Mar 14, 2026
Merged

Add -p to mkdir#4069
johanneskoester merged 2 commits intosnakemake:mainfrom
clelange:rules_example_followup

Conversation

@clelange
Copy link
Copy Markdown
Contributor

@clelange clelange commented Mar 12, 2026 •
edited by coderabbitai bot
Loading

Following up on PR #4043

Summary by CodeRabbit

  • Documentation
    • Updated shell command example in documentation to use the -p flag for directory creation, ensuring the command executes reliably when directories already exist.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 12, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 35612464-3624-494e-a995-d920911f7d86

📥 Commits

Reviewing files that changed from the base of the PR and between 588c1f7 and b999006.

📒 Files selected for processing (1)
  • docs/snakefiles/rules.rst
📝 Walkthrough

Walkthrough

Replaced a documented shell example mkdir my_directory/ with mkdir -p my_directory/ in the docs to make the command idempotent (succeeds if the directory already exists).

Changes

Cohort / File(s) Summary
Documentation Example Update
docs/snakefiles/rules.rst		 Changed shell example from mkdir my_directory/ to mkdir -p my_directory/ to use idempotent directory creation.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Add -p to mkdir #4069 — Makes the same documentation change replacing mkdir my_directory/ with mkdir -p my_directory/.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete and lacks required sections; it only mentions a follow-up reference without providing a description of changes or completing the QC checklist. Complete the description by adding details about the changes and checking the QC boxes for test coverage and documentation updates.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add -p to mkdir' is directly related to the main change in the changeset, which replaces 'mkdir my_directory/' with 'mkdir -p my_directory/' in documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 12, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@johanneskoester johanneskoester merged commit 0422875 into snakemake:main Mar 14, 2026
3 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johanneskoester johanneskoester johanneskoester approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clelange @johanneskoester