fix: show failed logs in generated unit tests#3771
Merged
johanneskoester merged 2 commits intoOct 3, 2025
Conversation
Contributor
📝 WalkthroughWalkthroughThe ruletest template for Snakemake unit tests now includes the "--show-failed-logs" flag in the subprocess invocation arguments, inserted between "-f" and "-j1". No other logic, control flow, or public interfaces were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
johanneskoester
approved these changes
Oct 3, 2025
johanneskoester
pushed a commit
that referenced
this pull request
Oct 3, 2025
🤖 I have created a release *beep* *boop* --- ## [9.11.9](v9.11.8...v9.11.9) (2025-10-03) ### Bug Fixes * Raise WorkflowError on empty file path in _IOFile.check ([#3769](#3769)) ([4249ff7](4249ff7)) * remove id field in notebook cells created by nbformat, thereby increasing compatibility with different jupyter versions ([#3767](#3767)) ([46cf3ed](46cf3ed)) * show failed logs in generated unit tests ([#3771](#3771)) ([61f4e9b](61f4e9b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kjohnsen
pushed a commit
to kjohnsen/snakemake
that referenced
this pull request
Dec 15, 2025
<!--Add a description of your PR here--> ### QC <!-- Make sure that you can tick the boxes below. --> * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Enabled automatic display of failed logs in Snakemake rule tests by adding the --show-failed-logs flag to the test invocation. * Improves visibility into failure causes during test runs without altering existing test behavior or configuration. * No changes to test logic; only command-line execution updated for clearer diagnostics. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Johannes Köster <johannes.koester@tu-dortmund.de>
kjohnsen
pushed a commit
to kjohnsen/snakemake
that referenced
this pull request
Dec 15, 2025
🤖 I have created a release *beep* *boop* --- ## [9.11.9](snakemake/snakemake@v9.11.8...v9.11.9) (2025-10-03) ### Bug Fixes * Raise WorkflowError on empty file path in _IOFile.check ([snakemake#3769](snakemake#3769)) ([4249ff7](snakemake@4249ff7)) * remove id field in notebook cells created by nbformat, thereby increasing compatibility with different jupyter versions ([snakemake#3767](snakemake#3767)) ([46cf3ed](snakemake@46cf3ed)) * show failed logs in generated unit tests ([snakemake#3771](snakemake#3771)) ([61f4e9b](snakemake@61f4e9b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).Summary by CodeRabbit