fix: fix recent regression when printing remote storage output or log files (local path shown instead of query)#3550
Conversation
… files (local path shown instead of query)
📝 WalkthroughWalkthroughThe changes update the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant fmt_iofile
participant annotate
Caller->>fmt_iofile: call with f, as_io=True
alt f has specific IO flag
fmt_iofile->>annotate: call with f_str, label
annotate-->>fmt_iofile: return annotated string with label
else no specific IO flag
fmt_iofile->>annotate: call with f_str (label=None)
annotate-->>fmt_iofile: return annotated string without label
end
fmt_iofile-->>Caller: return result
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)`**/*.py`: Do not try to improve formatting. Do not suggest type annotations for functions that are defined inside of functions or methods. Do not suggest type annotation of the `s...
⏰ Context from checks skipped due to timeout of 90000ms (35)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🤖 I have created a release *beep* *boop* --- ## [9.3.2](v9.3.1...v9.3.2) (2025-04-26) ### Bug Fixes * fix recent regression when printing remote storage output or log files (local path shown instead of query) ([#3550](#3550)) ([a1e93ce](a1e93ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
… files (local path shown instead of query) (snakemake#3550) <!--Add a description of your PR here--> ### QC <!-- Make sure that you can tick the boxes below. --> * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved handling of IO file annotations, ensuring that files without specific flags are now properly annotated. - **Refactor** - Enhanced flexibility by making the label parameter optional in the annotation process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
🤖 I have created a release *beep* *boop* --- ## [9.3.2](snakemake/snakemake@v9.3.1...v9.3.2) (2025-04-26) ### Bug Fixes * fix recent regression when printing remote storage output or log files (local path shown instead of query) ([snakemake#3550](snakemake#3550)) ([a1e93ce](snakemake@a1e93ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).Summary by CodeRabbit