test: Add pytest markers & skips, update docs to reflect changes#3417
Merged
johanneskoester merged 12 commits intosnakemake:mainfrom Mar 14, 2025
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe changes update the JSON-like test durations record by removing, adding, and modifying several test entries. Notable modifications include removing Changes
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (45)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
cademirch
approved these changes
Mar 13, 2025
Contributor
cademirch
left a comment
There was a problem hiding this comment.
The queue test failure is weird but I think is unrelated to this. These changes are great, will make testing way easier, especially with the pixi support you added earlier. Great work.
… for MacOS compatibility
johanneskoester
approved these changes
Mar 14, 2025
kjohnsen
pushed a commit
to kjohnsen/snakemake
that referenced
this pull request
Dec 15, 2025
…kemake#3417) <!--Add a description of your PR here--> - Some tests that that are related to s3 storage keep failing locally. I believe these require the S3 credentials (available as secretes in CI) so I've marked them with pytest as `needs_s3` and added a section to the docs regarding this. - I could instead have a marker skip automatically but unsure how this works at the moment and dont want to have it start skipping tests in CI/CD. - I've also updated the `.test_durations` files since it hasnt been updated in some time, and there are more tests. Side note: the docs havent updated due to the src layout not registering in ReadtheDocs. fixed: snakemake#3419 ### QC <!-- Make sure that you can tick the boxes below. --> * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Documentation** - Introduced a new guide on using test markers, providing clear instructions for running or excluding tests based on environment needs. - **Tests** - Revised and reorganized test configurations with adjusted timings and added numerous new test cases. - Enhanced test annotations to indicate dependencies on external resources and platform-specific conditions for improved clarity during execution. - Added support for macOS in the testing workflow, expanding the environment options. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests that that are related to s3 storage keep failing locally. I believe these require the S3 credentials (available as secretes in CI) so I've marked them with pytest as
needs_s3and added a section to the docs regarding this.I've also updated the
.test_durationsfiles since it hasnt been updated in some time, and there are more tests.Side note: the docs havent updated due to the src layout not registering in ReadtheDocs. fixed: #3419
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).Summary by CodeRabbit
Summary by CodeRabbit
Documentation
Tests