Skip to content

fix: unawaited coroutine sanitize_local_storage_copies#2972

Merged
johanneskoester merged 2 commits intosnakemake:mainfrom
laf070810:fix-unawaited-coroutine
Aug 12, 2024
Merged

fix: unawaited coroutine sanitize_local_storage_copies#2972
johanneskoester merged 2 commits intosnakemake:mainfrom
laf070810:fix-unawaited-coroutine

Conversation

@laf070810
Copy link
Copy Markdown
Contributor

Coroutine sanitize_local_storage_copies is unawaited, producing the following warning:

<path>/lib/python3.12/site-packages/snakemake/dag.py:1615: RuntimeWarning: coroutine 'DAG.sanitize_local_storage_copies' was never awaited
  self.sanitize_local_storage_copies()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

This PR fixes it.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarqubecloud
Copy link
Copy Markdown

@johanneskoester johanneskoester merged commit 715c572 into snakemake:main Aug 12, 2024
johanneskoester pushed a commit that referenced this pull request Aug 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.17.0](v8.16.0...v8.17.0)
(2024-08-13)


### Features

* fix job rate limiting with --max-jobs-per-second and introduce the
more flexible --max-jobs-per-timespan
([#3010](#3010))
([9c31257](9c31257))


### Bug Fixes

* Allow hyphens in config keys given on the command line.
([#2998](#2998))
([b70c0db](b70c0db))
* allowing trailing '+' in name patterns
([#3002](#3002))
([59150d3](59150d3))
* print message if not yet enough resources for executing further jobs
([b8df036](b8df036))
* unawaited coroutine sanitize_local_storage_copies
([#2972](#2972))
([715c572](715c572))


### Documentation

* Change sha256 checksum in docs to more realistic example
([#2987](#2987))
([16a5cf2](16a5cf2))
* Make it more clear that the cluster commands now require a plugin
([#2976](#2976))
([74134cf](74134cf))
* Update installation.rst to recommend Miniforge instead of Mambaforge
([#2975](#2975))
([0fc7619](0fc7619))
* use plain monospace font instead of theme default that changes &gt;=
into ≥
([cc17fc1](cc17fc1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants