Skip to content

feat: support for default value specification when using lookup helper function#2907

Merged
johanneskoester merged 2 commits intomainfrom
feat/lookup-default
Jun 5, 2024
Merged

feat: support for default value specification when using lookup helper function#2907
johanneskoester merged 2 commits intomainfrom
feat/lookup-default

Conversation

@johanneskoester
Copy link
Copy Markdown
Contributor

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johanneskoester johanneskoester merged commit 08e88e2 into main Jun 5, 2024
@johanneskoester johanneskoester deleted the feat/lookup-default branch June 5, 2024 10:34
johanneskoester pushed a commit that referenced this pull request Jun 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.13.0](v8.12.0...v8.13.0)
(2024-06-05)


### Features

* support for default value specification when using lookup helper
function ([#2907](#2907))
([08e88e2](08e88e2))


### Documentation

* add badge for bioconda version
([#2902](#2902))
([3f01348](3f01348))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
peterjc added a commit to peterjc/snakemake that referenced this pull request Sep 18, 2024
This does two things, first it moves the required ``within`` argument to its own line - previously it was too easily overlooked. See change in bdd732d

Second, it adds the ``default`` argument from 08e88e2 on PR snakemake#2907.
@peterjc peterjc mentioned this pull request Sep 18, 2024
2 tasks
johanneskoester pushed a commit that referenced this pull request Sep 19, 2024
This does two things, first it moves the required ``within`` argument to
its own line - previously it was too easily overlooked. See change in
bdd732d

Second, it adds the ``default`` argument from
08e88e2 on PR #2907.

<!--Add a description of your PR here-->

### QC
<!-- Make sure that you can tick the boxes below. -->

* [ ] The PR contains a test case for the changes or the changes are
already covered by an existing test case.
* [x] The documentation (`docs/`) is updated to reflect the changes or
this is not necessary (e.g. if the change does neither modify the
language nor the behavior or functionalities of Snakemake).


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Documentation**
- Updated the documentation to clarify that the `within` parameter is
now required for the `lookup` function.
- Introduced a new default value, `NODEFAULT`, for the `default`
parameter, enhancing clarity on function usage.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant