feat: support for default value specification when using lookup helper function#2907
Merged
johanneskoester merged 2 commits intomainfrom Jun 5, 2024
Merged
feat: support for default value specification when using lookup helper function#2907johanneskoester merged 2 commits intomainfrom
johanneskoester merged 2 commits intomainfrom
Conversation
|
johanneskoester
pushed a commit
that referenced
this pull request
Jun 5, 2024
🤖 I have created a release *beep* *boop* --- ## [8.13.0](v8.12.0...v8.13.0) (2024-06-05) ### Features * support for default value specification when using lookup helper function ([#2907](#2907)) ([08e88e2](08e88e2)) ### Documentation * add badge for bioconda version ([#2902](#2902)) ([3f01348](3f01348)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
peterjc
added a commit
to peterjc/snakemake
that referenced
this pull request
Sep 18, 2024
This does two things, first it moves the required ``within`` argument to its own line - previously it was too easily overlooked. See change in bdd732d Second, it adds the ``default`` argument from 08e88e2 on PR snakemake#2907.
johanneskoester
pushed a commit
that referenced
this pull request
Sep 19, 2024
This does two things, first it moves the required ``within`` argument to its own line - previously it was too easily overlooked. See change in bdd732d Second, it adds the ``default`` argument from 08e88e2 on PR #2907. <!--Add a description of your PR here--> ### QC <!-- Make sure that you can tick the boxes below. --> * [ ] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Updated the documentation to clarify that the `within` parameter is now required for the `lookup` function. - Introduced a new default value, `NODEFAULT`, for the `default` parameter, enhancing clarity on function usage. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).