Skip to content

fix: return set instead of list when just --quiet#2829

Merged
johanneskoester merged 2 commits intosnakemake:mainfrom
cademirch:fix-issue2825
Apr 28, 2024
Merged

fix: return set instead of list when just --quiet#2829
johanneskoester merged 2 commits intosnakemake:mainfrom
cademirch:fix-issue2825

Conversation

@cademirch
Copy link
Copy Markdown
Contributor

Description

Fixes #2825. parse_quietness should return a set since that is what setup_logger() expects.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johanneskoester johanneskoester merged commit eeb57e2 into snakemake:main Apr 28, 2024
johanneskoester pushed a commit that referenced this pull request Apr 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.11.1](v8.11.0...v8.11.1)
(2024-04-29)


### Bug Fixes

* check template rendering output for leaked input file paths
([#2850](#2850))
([433302e](433302e))
* do not distinguish between local and remote rules in dryrun
([74b99ec](74b99ec))
* omit norun jobs when determining remote storage input file retrieval
([#2854](#2854))
([37a7c7f](37a7c7f))
* Prevent binary log files to crash snakemake execution with
`show-failed-logs`
([#2827](#2827))
([8a80bda](8a80bda))
* replace pkg_resources for python 3.12
([#2831](#2831))
([ac144fc](ac144fc))
* return set instead of list when just --quiet
([#2829](#2829))
([eeb57e2](eeb57e2))
* small typo in error
([#2853](#2853))
([325a715](325a715))
* use keyword arguments in `_IOFile.open`
([#2847](#2847))
([50c84dc](50c84dc))


### Documentation

* fix typo and link for RO Crate
([#2851](#2851))
([cec0041](cec0041))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--dry-run --quiet fails on 8

2 participants