Skip to content

fix: removed distutils from snakemake#2312

Merged
johanneskoester merged 6 commits intosnakemake:mainfrom
maarten-k:packaging_fail_singularity
Jun 21, 2023
Merged

fix: removed distutils from snakemake#2312
johanneskoester merged 6 commits intosnakemake:mainfrom
maarten-k:packaging_fail_singularity

Conversation

@maarten-k
Copy link
Copy Markdown
Contributor

Description

Python 3.12 does not support the distutils library any more. Replaced with packaging package.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@maarten-k maarten-k changed the title remove distutils from snakemake fix: removed distutils from snakemake Jun 20, 2023
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 9b8c362 into snakemake:main Jun 21, 2023
johanneskoester pushed a commit that referenced this pull request Jun 22, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.29.0](v7.28.3...v7.29.0)
(2023-06-21)


### Features

* introduce --workflow-profile for additional workflow specific profiles
that overwrite global profiles; add ability to define key-value CLI
flags like --set-threads or --set-resources as multi-level dictionaries
in profile config yaml files
([#2310](#2310))
([9675c17](9675c17))


### Bug Fixes

* addressing [#2197](#2197)
by allowing 256 character account names in slurm
([#2198](#2198))
([ab58c65](ab58c65))
* removed distutils from snakemake
([#2312](#2312))
([9b8c362](9b8c362))
* Update __init__.py to move "file" param to "print"
([#2291](#2291))
([92352b6](92352b6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
johanneskoester added a commit that referenced this pull request Apr 28, 2024
### Description

Follow up to #2312, Python 3.12 also
[removed](https://docs.python.org/3.12/whatsnew/3.12.html#removed)
bundled `setuptools` (aka `pkg_resources`)

### QC

<!-- Make sure that you can tick the boxes below. -->

- [ ] The PR contains a test case for the changes or the changes are
already covered by an existing test case.
- [ ] The documentation (`docs/`) is updated to reflect the changes or
this is not necessary (e.g. if the change does neither modify the
language nor the behavior or functionalities of Snakemake).

Co-authored-by: Johannes Köster <johannes.koester@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants