Skip to content

fix: limit length of failed logs decorations#2125

Merged
johanneskoester merged 1 commit intosnakemake:mainfrom
ebete:fix-failed-log-output
Mar 13, 2023
Merged

fix: limit length of failed logs decorations#2125
johanneskoester merged 1 commit intosnakemake:mainfrom
ebete:fix-failed-log-output

Conversation

@ebete
Copy link
Copy Markdown
Contributor

@ebete ebete commented Feb 21, 2023

Description

Limit the maximum length of the decorations around the logfile output of a failed job (when --show-failed-logs is given) to 80.

Fixes #2101.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ebete ebete changed the title Limit length of decorations fix: limit length of decorations Feb 21, 2023
@ebete ebete changed the title fix: limit length of decorations fix: limit length of failed logs decorations Feb 21, 2023
@johanneskoester johanneskoester merged commit 6fc9243 into snakemake:main Mar 13, 2023
@ebete ebete deleted the fix-failed-log-output branch March 14, 2023 08:11
johanneskoester pushed a commit that referenced this pull request Mar 14, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.24.2](v7.24.1...v7.24.2)
(2023-03-14)


### Bug Fixes

* fix index out of bounds error raised by usage of workflow.source_path
called from input or params functions (thanks @AKBrueggemann)
([#2170](#2170))
([cf8e6e8](cf8e6e8))
* limit length of failed logs decorations
([#2125](#2125))
([6fc9243](6fc9243))
* raise error if callable is passed to expand.
([#2171](#2171))
([1f28476](1f28476))
* rounding for batch calculation
([#2064](#2064))
([cbdbf9b](cbdbf9b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--show-failed-logs creates excessive output

2 participants