Fix incorrect code when escape_html=true#930
Merged
wisskid merged 1 commit intosmarty-php:masterfrom Feb 5, 2024
wxiaoguang:fix-escape-5.0
Merged
Fix incorrect code when escape_html=true#930wisskid merged 1 commit intosmarty-php:masterfrom wxiaoguang:fix-escape-5.0
wisskid merged 1 commit intosmarty-php:masterfrom
wxiaoguang:fix-escape-5.0
Conversation
Contributor
Author
|
Hi @wisskid, is there any interest in this fix? 4.x also needs this fix IMO. |
Member
|
I think so. Can you clarify the actual error this causes? |
Contributor
Author
|
The function: But So, it needs to use |
wisskid
added a commit
that referenced
this pull request
Feb 5, 2024
wisskid
added a commit
that referenced
this pull request
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #928
When setting
escape_html=true, the following code:becomes:
The code:
(string) $a + $bis not correct, it should be(string) ($a + $b).