Return helpful error message when root is not found #1893
Merged
+15
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a8bcd7 to
38733da
Compare
hslatman
reviewed
Jun 20, 2024
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
hslatman
approved these changes
Jan 7, 2026
hslatman
added a commit
that referenced
this pull request
Jan 7, 2026
Broken test was merged as part of #1893.
hslatman
added a commit
that referenced
this pull request
Jan 7, 2026
Broken test was merged as part of #1893.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes smallstep/cli#841.
Surprisingly (to me),
errs.NotFounddoes NOT return an errors that JSON-serializes the error message. Instead, it always serializes the default error message ("The requested resource could not be found. Please see the certificate authority logs for more info.").I assume this is intended to hide internals of the error (although this isn't documented anywhere), so I didn't change this behavior. Instead, I'm using the slightly convoluted
errs.NotFoundErrwith an option to create an error that actually serializes the error message we want to display to the user. I also updated the test case to check for this message.